From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1888) id 710EE3858D35; Wed, 4 Jan 2023 19:13:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 710EE3858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1672859601; bh=BoQ54EUMp6h3mi5pXUU+LhvE3U+9jNnITzNpagjRyRM=; h=From:To:Subject:Date:From; b=nA2ffCLtr1EQ/LyT26OUCkIO7KCptJQQJuDaDjckficZOpN8wZLsyIFkRCd1EhM0c x0ZZoLDoRwwn4epG1jYX752lvZkxjKC+zN/EpkD8kKi2WquWjxXVTsHI0nP453m3We T772OgilezXgMfrkxXlbJNwSWMU8dQB10I1ik6AE= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Patrick Palka To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5000] c++: mark_single_function and SFINAE [PR108282] X-Act-Checkin: gcc X-Git-Author: Patrick Palka X-Git-Refname: refs/heads/master X-Git-Oldrev: fc349931adcf1024ee95e0a0cd98cf4a41996093 X-Git-Newrev: 238e292cf5d822f3bd12d9b58eb04cf377758b2a Message-Id: <20230104191321.710EE3858D35@sourceware.org> Date: Wed, 4 Jan 2023 19:13:21 +0000 (GMT) List-Id: https://gcc.gnu.org/g:238e292cf5d822f3bd12d9b58eb04cf377758b2a commit r13-5000-g238e292cf5d822f3bd12d9b58eb04cf377758b2a Author: Patrick Palka Date: Wed Jan 4 14:12:25 2023 -0500 c++: mark_single_function and SFINAE [PR108282] We typically ignore mark_used failure when in a non-SFINAE context for sake of better error recovery. But in mark_single_function we're instead ignoring mark_used failure in a SFINAE context, which ends up causing the second static_assert here to incorrectly fail. PR c++/108282 gcc/cp/ChangeLog: * decl2.cc (mark_single_function): Ignore mark_used failure only in a non-SFINAE context rather than in a SFINAE one. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/concepts-requires34.C: New test. Diff: --- gcc/cp/decl2.cc | 2 +- gcc/testsuite/g++.dg/cpp2a/concepts-requires34.C | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/gcc/cp/decl2.cc b/gcc/cp/decl2.cc index f95529a5c9a..00ed64d1691 100644 --- a/gcc/cp/decl2.cc +++ b/gcc/cp/decl2.cc @@ -5600,7 +5600,7 @@ mark_single_function (tree expr, tsubst_flags_t complain) if (is_overloaded_fn (expr) == 1 && !mark_used (expr, complain) - && (complain & tf_error)) + && !(complain & tf_error)) return false; return true; } diff --git a/gcc/testsuite/g++.dg/cpp2a/concepts-requires34.C b/gcc/testsuite/g++.dg/cpp2a/concepts-requires34.C new file mode 100644 index 00000000000..5bbd62f6d8e --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/concepts-requires34.C @@ -0,0 +1,19 @@ +// PR c++/108282 +// { dg-do compile { target c++20 } } + +template +concept TEST = requires { T::TT; }; + +struct C { }; + +template +struct B { + static void TT() requires TEST; +}; + +int main() { + static_assert( !TEST ); + static_assert( !TEST> ); + + B::TT(); // { dg-error "no match" } +}