public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Rainer Orth <ro@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5222] libsanitizer: Fix asan SEGVs with gld on Solaris
Date: Tue, 17 Jan 2023 09:56:54 +0000 (GMT)	[thread overview]
Message-ID: <20230117095654.D0B0B3858D28@sourceware.org> (raw)

https://gcc.gnu.org/g:85b45cccdf5f2442e791969abbffffbb2676591f

commit r13-5222-g85b45cccdf5f2442e791969abbffffbb2676591f
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Tue Jan 17 10:56:20 2023 +0100

    libsanitizer: Fix asan SEGVs with gld on Solaris
    
    When using GNU ld on Solaris, a large number of asan tests SEGV, while
    Solaris ld is fine.  This happens inside the __tls_get_addr interceptor,
    which is highly glibc-specific.  Therefore this patch disables that
    interceptor.
    
    Posted upstream at https://reviews.llvm.org/D141385.
    
    Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11.
    
    2023-01-17  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
            libsanitizer:
            * sanitizer_common/sanitizer_platform_interceptors.h: Cherry-pick
            llvm-project revision 951cf656b2faaf6fc0baa867293c0cb0ab131951.

Diff:
---
 libsanitizer/sanitizer_common/sanitizer_platform_interceptors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libsanitizer/sanitizer_common/sanitizer_platform_interceptors.h b/libsanitizer/sanitizer_common/sanitizer_platform_interceptors.h
index 6e3081ec1fc..8307b1ec28b 100644
--- a/libsanitizer/sanitizer_common/sanitizer_platform_interceptors.h
+++ b/libsanitizer/sanitizer_common/sanitizer_platform_interceptors.h
@@ -405,7 +405,7 @@
   (SI_FREEBSD || SI_NETBSD || SI_GLIBC || SI_SOLARIS)
 
 #define SANITIZER_INTERCEPT_TLS_GET_ADDR \
-  (SI_FREEBSD || SI_NETBSD || SI_LINUX_NOT_ANDROID || SI_SOLARIS)
+  (SI_FREEBSD || SI_NETBSD || SI_LINUX_NOT_ANDROID)
 
 #define SANITIZER_INTERCEPT_LISTXATTR SI_LINUX
 #define SANITIZER_INTERCEPT_GETXATTR SI_LINUX

                 reply	other threads:[~2023-01-17  9:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117095654.D0B0B3858D28@sourceware.org \
    --to=ro@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).