From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id 18D523858D28; Tue, 17 Jan 2023 19:39:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 18D523858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1673984343; bh=xMTverZswVLb9b6p05/w45oC/gJLoV7dWRBVMGL0raI=; h=From:To:Subject:Date:From; b=Nzzf+V09ZCQOMK8olEXMWG8b7Cxl7BCsL/z4Bn2iqNekn8dSS6808wNT8jGdaCuWl 1fA+0+vG21mkpWFFnT2IUd9EkkJXCDTft4Uh+zPLB0/CcjL2q4OPE1WMAGacIBr/3h LbRCFM1oolddflgs2Icff0cSlhTaOZq+/BGNsvfI= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5232] Fortran: fix ICE in get_expr_storage_size [PR108421] X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/master X-Git-Oldrev: 6d80690132a2f00fae1f619d4ffd950ce8cfdbc7 X-Git-Newrev: a75760374ee54768e5fd6a27080698bfbbd041ab Message-Id: <20230117193903.18D523858D28@sourceware.org> Date: Tue, 17 Jan 2023 19:39:03 +0000 (GMT) List-Id: https://gcc.gnu.org/g:a75760374ee54768e5fd6a27080698bfbbd041ab commit r13-5232-ga75760374ee54768e5fd6a27080698bfbbd041ab Author: Harald Anlauf Date: Mon Jan 16 21:30:56 2023 +0100 Fortran: fix ICE in get_expr_storage_size [PR108421] gcc/fortran/ChangeLog: PR fortran/108421 * interface.cc (get_expr_storage_size): Check that we actually have an integer value before trying to extract it with mpz_get_si. gcc/testsuite/ChangeLog: PR fortran/108421 * gfortran.dg/pr108421.f90: New test. Diff: --- gcc/fortran/interface.cc | 3 ++- gcc/testsuite/gfortran.dg/pr108421.f90 | 11 +++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc index c4f7faaf597..9593fa83c45 100644 --- a/gcc/fortran/interface.cc +++ b/gcc/fortran/interface.cc @@ -2858,7 +2858,8 @@ get_expr_storage_size (gfc_expr *e) if (e->ts.type == BT_CHARACTER) { if (e->ts.u.cl && e->ts.u.cl->length - && e->ts.u.cl->length->expr_type == EXPR_CONSTANT) + && e->ts.u.cl->length->expr_type == EXPR_CONSTANT + && e->ts.u.cl->length->ts.type == BT_INTEGER) strlen = mpz_get_si (e->ts.u.cl->length->value.integer); else if (e->expr_type == EXPR_CONSTANT && (e->ts.u.cl == NULL || e->ts.u.cl->length == NULL)) diff --git a/gcc/testsuite/gfortran.dg/pr108421.f90 b/gcc/testsuite/gfortran.dg/pr108421.f90 new file mode 100644 index 00000000000..89439bc7eec --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr108421.f90 @@ -0,0 +1,11 @@ +! { dg-do compile } +! PR fortran/108421 +! Contributed by G.Steinmetz + +program p + character(real(3)) :: c ! { dg-error "must be of INTEGER type" } + call s(c) +end +subroutine s(x) + character(*) :: x +end