public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-5243] ipa: Release body more carefully when removing nodes (PR 107944)
@ 2023-01-18 14:44 Martin Jambor
0 siblings, 0 replies; only message in thread
From: Martin Jambor @ 2023-01-18 14:44 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:db959e250077ae6b4fc08f53fb322719582c5de6
commit r13-5243-gdb959e250077ae6b4fc08f53fb322719582c5de6
Author: Martin Jambor <mjambor@suse.cz>
Date: Wed Jan 18 15:29:54 2023 +0100
ipa: Release body more carefully when removing nodes (PR 107944)
The code removing function bodies when the last call graph clone of a
node is removed is too aggressive when there are nodes up the
clone_of chain which still need them. Fixed by expanding the check.
gcc/ChangeLog:
2023-01-18 Martin Jambor <mjambor@suse.cz>
PR ipa/107944
* cgraph.cc (cgraph_node::remove): Check whether nodes up the
lcone_of chain also do not need the body.
Diff:
---
gcc/cgraph.cc | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/gcc/cgraph.cc b/gcc/cgraph.cc
index 5e60c2b73db..5f72ace9b57 100644
--- a/gcc/cgraph.cc
+++ b/gcc/cgraph.cc
@@ -1893,8 +1893,18 @@ cgraph_node::remove (void)
else if (clone_of)
{
clone_of->clones = next_sibling_clone;
- if (!clone_of->analyzed && !clone_of->clones && !clones)
- clone_of->release_body ();
+ if (!clones)
+ {
+ bool need_body = false;
+ for (cgraph_node *n = clone_of; n; n = n->clone_of)
+ if (n->analyzed || n->clones)
+ {
+ need_body = true;
+ break;
+ }
+ if (!need_body)
+ clone_of->release_body ();
+ }
}
if (next_sibling_clone)
next_sibling_clone->prev_sibling_clone = prev_sibling_clone;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-18 14:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18 14:44 [gcc r13-5243] ipa: Release body more carefully when removing nodes (PR 107944) Martin Jambor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).