public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tobias Burnus <burnus@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5250] libfortran: Fix execute_command_line for Windows
Date: Wed, 18 Jan 2023 22:32:07 +0000 (GMT)	[thread overview]
Message-ID: <20230118223207.32ED53858288@sourceware.org> (raw)

https://gcc.gnu.org/g:8e2c6e7b426b6c9c13076208b2e176d4aa1432f1

commit r13-5250-g8e2c6e7b426b6c9c13076208b2e176d4aa1432f1
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Wed Jan 18 23:31:41 2023 +0100

    libfortran: Fix execute_command_line for Windows
    
    On Windows, 'system' is called - that fails with -1 if the command
    interpreter could not be started; on POSIX systems, if the child
    process could not be started by the shell, exit(127)/_exit(127) is
    called/returned. On Windows, cmd.exe (and also the PowerShell) return
    errorlevel 9009.
    
    libgfortran/ChangeLog:
    
            * intrinsics/execute_command_line.c (execute_command_line): On
            Windows, regard system()'s return value of 9009 as EXEC_INVALIDCOMMAND.

Diff:
---
 libgfortran/intrinsics/execute_command_line.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libgfortran/intrinsics/execute_command_line.c b/libgfortran/intrinsics/execute_command_line.c
index 305f067d973..0d1688400c2 100644
--- a/libgfortran/intrinsics/execute_command_line.c
+++ b/libgfortran/intrinsics/execute_command_line.c
@@ -144,6 +144,11 @@ execute_command_line (const char *command, bool wait, int *exitstat,
 #if defined(WEXITSTATUS) && defined(WIFEXITED)
 	       || (WIFEXITED(res) && WEXITSTATUS(res) == 127)
 	       || (WIFEXITED(res) && WEXITSTATUS(res) == 126)
+#endif
+#ifdef __MINGW32__
+		  /* cmd.exe sets the errorlevel to 9009,
+		     if the command could not be executed.  */
+		|| res == 9009
 #endif
 	       )
 	/* Shell return codes 126 and 127 mean that the command line could

                 reply	other threads:[~2023-01-18 22:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230118223207.32ED53858288@sourceware.org \
    --to=burnus@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).