public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/omp/gcc-12] Fix 'libgomp.c/simd-math-1.c' configuration Date: Fri, 20 Jan 2023 14:14:53 +0000 (GMT) [thread overview] Message-ID: <20230120141453.365513858D1E@sourceware.org> (raw) https://gcc.gnu.org/g:e7d4bcb974915bfe95be6c385641fc66a4201581 commit e7d4bcb974915bfe95be6c385641fc66a4201581 Author: Thomas Schwinge <thomas@codesourcery.com> Date: Sat Jan 14 10:28:09 2023 +0100 Fix 'libgomp.c/simd-math-1.c' configuration If nvptx offloading is configured in addition to GCN, we see: FAIL: libgomp.c/simd-math-1.c (test for excess errors) UNRESOLVED: libgomp.c/simd-math-1.c compilation failed to produce executable x86_64-pc-linux-gnu-accel-nvptx-none-gcc: error: unrecognized command-line option '-mstack-size=3000000' Thus, restrict that ooption to GCN offloading compilation, and on the other hand, there's no reason to skip this test for non-GCN offloading execution: even if not SIMD-vectorized there, we still benefit from correctness testing. libgomp/ * testsuite/libgomp.c/simd-math-1.c: Fix configuration. Diff: --- libgomp/ChangeLog.omp | 4 ++++ libgomp/testsuite/libgomp.c/simd-math-1.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp index 629efbc5832..23e93495b62 100644 --- a/libgomp/ChangeLog.omp +++ b/libgomp/ChangeLog.omp @@ -1,3 +1,7 @@ +2023-01-20 Thomas Schwinge <thomas@codesourcery.com> + + * testsuite/libgomp.c/simd-math-1.c: Fix configuration. + 2023-01-19 Tobias Burnus <tobias@codesourcery.com> Backported from master: diff --git a/libgomp/testsuite/libgomp.c/simd-math-1.c b/libgomp/testsuite/libgomp.c/simd-math-1.c index caf032a77ae..1ebdccccfeb 100644 --- a/libgomp/testsuite/libgomp.c/simd-math-1.c +++ b/libgomp/testsuite/libgomp.c/simd-math-1.c @@ -2,9 +2,9 @@ sufficiently close) results as their scalar equivalents. */ /* { dg-do run } */ -/* { dg-skip-if "AMD GCN only" { ! amdgcn_offloading_enabled } } */ /* { dg-options "-O2 -ftree-vectorize -fno-math-errno" } */ -/* { dg-additional-options "-foffload=-mstack-size=3000000 -foffload=-lm" } */ +/* { dg-additional-options -foffload-options=amdgcn-amdhsa=-mstack-size=3000000 } */ +/* { dg-additional-options -foffload-options=-lm } */ #undef PRINT_RESULT #define VERBOSE 0
reply other threads:[~2023-01-20 14:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230120141453.365513858D1E@sourceware.org \ --to=tschwinge@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).