From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 5466B3858412; Thu, 26 Jan 2023 12:49:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5466B3858412 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1674737389; bh=RJkFAPbbECSlBEbtQ0edQy8g+/grsI6IrMJHWLHCo48=; h=From:To:Subject:Date:From; b=c69duCrLYLtPU+ub9KMC9XLxztc3ssGTjf0YqXOk8EUZ/ucyUS2vcqfnd1cSBqfFn b7tDUuoiqbOwmgrHdtJml4r35Ulmh1XT3f0KPnRH5NmtyHqTmNvtqDm9pjXiucpqgb CkcryfLcK5w6MrJPvLBOBxY5X0TTvk0JztnDSxKI= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5383] tree-optimization/108547 - robustify uninit predicate analysis X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 0573a0778af88e805f7630ac8640ecd67d692665 X-Git-Newrev: c71a128a3e1ff6ee5274fc2df49ea650bc9e6c2d Message-Id: <20230126124949.5466B3858412@sourceware.org> Date: Thu, 26 Jan 2023 12:49:49 +0000 (GMT) List-Id: https://gcc.gnu.org/g:c71a128a3e1ff6ee5274fc2df49ea650bc9e6c2d commit r13-5383-gc71a128a3e1ff6ee5274fc2df49ea650bc9e6c2d Author: Richard Biener Date: Thu Jan 26 08:59:20 2023 +0100 tree-optimization/108547 - robustify uninit predicate analysis Predicate analysis, when looking through casts doesn't bother to convert boundary constants to the type of the bounded variables. The following robustifies value_sat_pred_p to use widest_ints to deal with this, like other code in predicate analysis. PR tree-optimization/108547 * gimple-predicate-analysis.cc (value_sat_pred_p): Use widest_int. * gcc.dg/uninit-pr108547.c: New testcase. Diff: --- gcc/gimple-predicate-analysis.cc | 6 +++--- gcc/testsuite/gcc.dg/uninit-pr108547.c | 24 ++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index a7719ff493f..094e8c7aff3 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -728,11 +728,11 @@ value_sat_pred_p (tree val, tree boundary, tree_code cmpc, if (cmpc != BIT_AND_EXPR) return is_value_included_in (val, boundary, cmpc); - wide_int andw = wi::to_wide (val) & wi::to_wide (boundary); + widest_int andw = wi::to_widest (val) & wi::to_widest (boundary); if (exact_p) - return andw == wi::to_wide (val); + return andw == wi::to_widest (val); - return andw.to_uhwi (); + return wi::ne_p (andw, 0); } /* Return true if the domain of single predicate expression PRED1 diff --git a/gcc/testsuite/gcc.dg/uninit-pr108547.c b/gcc/testsuite/gcc.dg/uninit-pr108547.c new file mode 100644 index 00000000000..d8f6c9ff87a --- /dev/null +++ b/gcc/testsuite/gcc.dg/uninit-pr108547.c @@ -0,0 +1,24 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -Wuninitialized" } */ + +int func_7_uc_10li_19 (int); +int li_4, li_5, us_8; +unsigned char func_7_ptr_13, func_7_uc_14; +void func_7_ptr_18() { + if (li_5) { + for (;;) + ; + short s_15; + for (; func_7_uc_14;) { + us_8 = 7; + for (; us_8; us_8 += 1) + lblD2AF1FAB: + if (us_8) + li_4 = 1; + func_7_uc_14 += (__INTPTR_TYPE__)func_7_ptr_18; + if (func_7_ptr_13 & 1 && (func_7_uc_14 &= func_7_ptr_13)) + s_15 %= func_7_uc_10li_19(s_15); /* { dg-warning "uninitialized" } */ + } + } + goto lblD2AF1FAB; +}