public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5437] doc: Fix up return type of __builtin_va_arg_pack_len [PR108560]
Date: Fri, 27 Jan 2023 10:18:23 +0000 (GMT)	[thread overview]
Message-ID: <20230127101823.BDB933858D20@sourceware.org> (raw)

https://gcc.gnu.org/g:16f30680f403891556da2ad6329fcef9dc9b47db

commit r13-5437-g16f30680f403891556da2ad6329fcef9dc9b47db
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jan 27 11:17:35 2023 +0100

    doc: Fix up return type of __builtin_va_arg_pack_len [PR108560]
    
    __builtin_va_arg_pack_len as implemented returned int since its introduction
    in 2007.  The initial documentation didn't mention any return type,
    which changed in 2010 in r0-103077-gab940b73bfabe2cec4 during some
    documentation formatting cleanups
    https://gcc.gnu.org/legacy-ml/gcc-patches/2010-09/msg01632.html
    I can understand that for formatting some type was needed there
    but what exactly hasn't been really discussed.
    
    So, I think we should change documentation to match the implementation,
    rather than change implementation to match the documentation.
    Most people don't use more than 2147483647 arguments to inline functions,
    and on poor targets with 16-bit ints I bet even having more than 65535
    arguments to inline functions would be highly unexpected.
    
    2023-01-27  Jakub Jelinek  <jakub@redhat.com>
    
            PR other/108560
            * doc/extend.texi: Fix up return type of __builtin_va_arg_pack_len
            from size_t to int.

Diff:
---
 gcc/doc/extend.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
index 4a89a3eae7c..027a08a2f62 100644
--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -688,7 +688,7 @@ myprintf (FILE *f, const char *format, ...)
 @end smallexample
 @end deftypefn
 
-@deftypefn {Built-in Function} {size_t} __builtin_va_arg_pack_len ()
+@deftypefn {Built-in Function} {int} __builtin_va_arg_pack_len ()
 This built-in function returns the number of anonymous arguments of
 an inline function.  It can be used only in inline functions that
 are always inlined, never compiled as a separate function, such

                 reply	other threads:[~2023-01-27 10:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230127101823.BDB933858D20@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).