public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Philipp Tomsich <ptomsich@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5482] aarch64: Correct the maximum shift amount for shifted operands
Date: Sat, 28 Jan 2023 23:08:14 +0000 (GMT)	[thread overview]
Message-ID: <20230128230814.B93A83858D20@sourceware.org> (raw)

https://gcc.gnu.org/g:2f2101c87ac88a9fa9f7b4a264fb7738118c7fc9

commit r13-5482-g2f2101c87ac88a9fa9f7b4a264fb7738118c7fc9
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date:   Sun Jan 29 00:07:09 2023 +0100

    aarch64: Correct the maximum shift amount for shifted operands
    
    The aarch64 ISA specification allows a left shift amount to be applied
    after extension in the range of 0 to 4 (encoded in the imm3 field).
    
    This is true for at least the following instructions:
    
     * ADD (extend register)
     * ADDS (extended register)
     * SUB (extended register)
    
    The result of this patch can be seen, when compiling the following code:
    
    uint64_t myadd(uint64_t a, uint64_t b)
    {
        return a+(((uint8_t)b)<<4);
    }
    
    Without the patch the following sequence will be generated:
    
    0000000000000000 <myadd>:
       0:   d37c1c21        ubfiz   x1, x1, #4, #8
       4:   8b000020        add     x0, x1, x0
       8:   d65f03c0        ret
    
    With the patch the ubfiz will be merged into the add instruction:
    
    0000000000000000 <myadd>:
       0:   8b211000        add     x0, x0, w1, uxtb #4
       4:   d65f03c0        ret
    
    gcc/ChangeLog:
    
            * config/aarch64/aarch64.cc (aarch64_uxt_size): fix an
            off-by-one in checking the permissible shift-amount.

Diff:
---
 gcc/config/aarch64/aarch64.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
index 089c1c85845..17c1e23e5b5 100644
--- a/gcc/config/aarch64/aarch64.cc
+++ b/gcc/config/aarch64/aarch64.cc
@@ -13022,7 +13022,7 @@ aarch64_output_casesi (rtx *operands)
 int
 aarch64_uxt_size (int shift, HOST_WIDE_INT mask)
 {
-  if (shift >= 0 && shift <= 3)
+  if (shift >= 0 && shift <= 4)
     {
       int size;
       for (size = 8; size <= 32; size *= 2)

                 reply	other threads:[~2023-01-28 23:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230128230814.B93A83858D20@sourceware.org \
    --to=ptomsich@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).