public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5489] ipa/108511 - relax assert for undefined local statics
Date: Mon, 30 Jan 2023 08:35:25 +0000 (GMT)	[thread overview]
Message-ID: <20230130083525.731CD3858407@sourceware.org> (raw)

https://gcc.gnu.org/g:4c17371dc5a1193671e5a475349fa7d7a6f0ca1c

commit r13-5489-g4c17371dc5a1193671e5a475349fa7d7a6f0ca1c
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Jan 30 08:20:03 2023 +0100

    ipa/108511 - relax assert for undefined local statics
    
    Since we no longer promote undefined local statics extern the
    assert in possibly_call_in_translation_unit_p triggers.  The
    following relaxes it according to Honzas advice.
    
            PR ipa/108511
            * cgraph.cc (possibly_call_in_translation_unit_p): Relax
            assert.

Diff:
---
 gcc/cgraph.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/cgraph.cc b/gcc/cgraph.cc
index b810237c919..06bc980fa52 100644
--- a/gcc/cgraph.cc
+++ b/gcc/cgraph.cc
@@ -4183,7 +4183,7 @@ cgraph_edge::possibly_call_in_translation_unit_p (void)
     node = node->previous_sharing_asm_name;
   if (node->previous_sharing_asm_name)
     node = symtab_node::get_for_asmname (DECL_ASSEMBLER_NAME (callee->decl));
-  gcc_assert (TREE_PUBLIC (node->decl));
+  gcc_assert (TREE_PUBLIC (node->decl) || DECL_EXTERNAL (node->decl));
   return node->get_availability () >= AVAIL_INTERPOSABLE;
 }

                 reply	other threads:[~2023-01-30  8:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230130083525.731CD3858407@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).