public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Rainer Orth <ro@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5494] testsuite: Restore TORTURE_OPTIONS in gm2/warnings/returntype/fail/warnings-returntype-fail.exp
Date: Mon, 30 Jan 2023 13:26:42 +0000 (GMT)	[thread overview]
Message-ID: <20230130132642.243D93858C36@sourceware.org> (raw)

https://gcc.gnu.org/g:7c4d1b7a44009c7b89f3aff6e014c4a19563e82e

commit r13-5494-g7c4d1b7a44009c7b89f3aff6e014c4a19563e82e
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Mon Jan 30 14:26:06 2023 +0100

    testsuite: Restore TORTURE_OPTIONS in gm2/warnings/returntype/fail/warnings-returntype-fail.exp
    
    Between 20230126 and 20230127, 1100+ gm2 tests started to FAIL for the
    non-default multilib, e.g.
    
    FAIL: gm2/calling-c/datatypes/unbounded/run/pass/m.mod compilation,
    {additional_flags= -O0 -g -Werror=return-type } timeout=10
    UNRESOLVED: gm2/calling-c/datatypes/unbounded/run/pass/m.mod execution,
    {additional_flags= -O0 -g -Werror=return-type } timeout=10
    FAIL: gm2/case/pass/testcase1.mod,  -O0 -g -Werror=return-type
    [...]
    cc1gm2: warning: '-Werror=' argument '-Werror=return-type' is not valid for
    Modula-2
    
    I'm seeing this on all of Solaris/x86, Solaris/SPARC, and Linux/x86_64.
    
    I could trace this to
    gm2/warnings/returntype/fail/warnings-returntype-fail.exp not properly
    restoring TORTURE_OPTIONS.
    
    Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11.
    
    2023-01-30  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
            gcc/testsuite:
            * gm2/warnings/returntype/fail/warnings-returntype-fail.exp: Save,
            restore TORTURE_OPTIONS.

Diff:
---
 .../gm2/warnings/returntype/fail/warnings-returntype-fail.exp         | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp
index aaebe1f07dd..43e97babec7 100644
--- a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp
+++ b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp
@@ -28,6 +28,8 @@ load_lib gm2-torture.exp
 gm2_init_pim "${srcdir}/gm2/warnings/returntype/fail"
 
 global TORTURE_OPTIONS
+
+set old_options $TORTURE_OPTIONS
 set TORTURE_OPTIONS { { -O0 -g -Werror=return-type } }
 
 foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.mod]] {
@@ -38,3 +40,5 @@ foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.mod]] {
 
     gm2-torture-fail $testcase
 }
+
+set TORTURE_OPTIONS $old_options

                 reply	other threads:[~2023-01-30 13:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230130132642.243D93858C36@sourceware.org \
    --to=ro@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).