public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Macleod <amacleod@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-9091] Correctly detect shifts out of range Date: Mon, 30 Jan 2023 21:12:20 +0000 (GMT) [thread overview] Message-ID: <20230130211220.EF4C23858D1E@sourceware.org> (raw) https://gcc.gnu.org/g:9dccaeaa586a1634e1f6a0f4c51806f3c3aea63b commit r12-9091-g9dccaeaa586a1634e1f6a0f4c51806f3c3aea63b Author: Andrew MacLeod <amacleod@redhat.com> Date: Mon Jan 30 14:59:30 2023 -0500 Correctly detect shifts out of range get_shift_range was incorrectly communicating that it couldn't calculate a range when the shift values was always out fo range. Fix this and alwasy return [0, 0] when the shift value is always out of range. PR tree-optimization/108306 gcc/ * range-op.cc (operator_lshift::fold_range): Return [0, 0] not varying for shifts that are always out of void range. (operator_rshift::fold_range): Return [0, 0] not varying for shifts that are always out of void range. gcc/testsuite/ * gcc.dg/pr108306.c: New. Diff: --- gcc/range-op.cc | 4 ++-- gcc/testsuite/gcc.dg/pr108306.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/gcc/range-op.cc b/gcc/range-op.cc index b5f4627fe2b..bf95f5fbaa1 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -1970,7 +1970,7 @@ operator_lshift::fold_range (irange &r, tree type, if (op2.undefined_p ()) r.set_undefined (); else - r.set_varying (type); + r.set_zero (type); return true; } @@ -2240,7 +2240,7 @@ operator_rshift::fold_range (irange &r, tree type, if (op2.undefined_p ()) r.set_undefined (); else - r.set_varying (type); + r.set_zero (type); return true; } diff --git a/gcc/testsuite/gcc.dg/pr108306.c b/gcc/testsuite/gcc.dg/pr108306.c new file mode 100644 index 00000000000..1044c646de7 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr108306.c @@ -0,0 +1,29 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fno-strict-overflow -fsanitize=shift -Warray-bounds" } */ + +enum psi_task_count { + NR_IOWAIT, + NR_PSI_TASK_COUNTS = 4, +}; + +unsigned int tasks[NR_PSI_TASK_COUNTS]; + +static void psi_group_change(unsigned int set) +{ + unsigned int t; + unsigned int state_mask = 0; + + for (t = 0; set; set &= ~(1 << t), t++) + if (set & (1 << t)) + tasks[t]++; +} + +void psi_task_switch(int sleep) +{ + int set = 0; + + if (sleep) + set |= (1 << NR_IOWAIT); + + psi_group_change(set); +}
reply other threads:[~2023-01-30 21:12 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230130211220.EF4C23858D1E@sourceware.org \ --to=amacleod@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).