public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5528] testsuite/108604 - gcc.dg/torture/pr108574-3.c hangs on unsigned char archs
Date: Tue, 31 Jan 2023 08:50:53 +0000 (GMT)	[thread overview]
Message-ID: <20230131085053.A70553858D1E@sourceware.org> (raw)

https://gcc.gnu.org/g:78d6489f736963a8a07c494294c72662c49e8e63

commit r13-5528-g78d6489f736963a8a07c494294c72662c49e8e63
Author: Xianmiao Qu <cooper.qu@linux.alibaba.com>
Date:   Tue Jan 31 09:49:06 2023 +0100

    testsuite/108604 - gcc.dg/torture/pr108574-3.c hangs on unsigned char archs
    
    In the architecture where sign defaults to unsigned, the 'f' will be zero
    extended to int type in the expression 'd = ~(f & ~2880764155)', then the
    'd' will become -1 wich cause the case to fail.
    So it's ok for the architectures where sign defaults to signed like x86,
    but failed for the architectures where sign defaults to unsigned like arm
    and csky. Change char to signed char to avoid this problem.
    
            PR testsuite/108604
    gcc/testsuite:
            * gcc.dg/torture/pr108574-3.c (b, f): Change type from char to
            signed char.

Diff:
---
 gcc/testsuite/gcc.dg/torture/pr108574-3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/torture/pr108574-3.c b/gcc/testsuite/gcc.dg/torture/pr108574-3.c
index 3c9146e31ac..b4d5dae9f80 100644
--- a/gcc/testsuite/gcc.dg/torture/pr108574-3.c
+++ b/gcc/testsuite/gcc.dg/torture/pr108574-3.c
@@ -1,7 +1,7 @@
 /* { dg-do run } */
 
 int a = 3557301289, d;
-char b, f;
+signed char b, f;
 unsigned short c = 241;
 short e, g;
 static void h() {

                 reply	other threads:[~2023-01-31  8:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131085053.A70553858D1E@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).