public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Arthur Cohen <cohenarthur@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5556] gccrs: backend: correctly formulate the exit condition ...
Date: Tue, 31 Jan 2023 13:16:08 +0000 (GMT)	[thread overview]
Message-ID: <20230131131608.CDC593854801@sourceware.org> (raw)

https://gcc.gnu.org/g:e6a3886a833a0c499ab20a828ffae79076d47a4d

commit r13-5556-ge6a3886a833a0c499ab20a828ffae79076d47a4d
Author: liushuyu <liushuyu011@gmail.com>
Date:   Mon Sep 5 17:56:03 2022 -0600

    gccrs: backend: correctly formulate the exit condition ...
    
    ... previously the exit condition was treated the same as the loop
    condition (which is the inverse condition of the exit condition). Now
    this is corrected.
    
    gcc/rust/ChangeLog:
    
            * backend/rust-compile-expr.cc (CompileExpr::visit): Properly formulate
            exit condition when compiling while loops.
    
    Signed-off-by: Zixing Liu <liushuyu011@gmail.com>

Diff:
---
 gcc/rust/backend/rust-compile-expr.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gcc/rust/backend/rust-compile-expr.cc b/gcc/rust/backend/rust-compile-expr.cc
index ea146731cbe..d58e2258947 100644
--- a/gcc/rust/backend/rust-compile-expr.cc
+++ b/gcc/rust/backend/rust-compile-expr.cc
@@ -727,8 +727,11 @@ CompileExpr::visit (HIR::WhileLoopExpr &expr)
 
   tree condition
     = CompileExpr::Compile (expr.get_predicate_expr ().get (), ctx);
+  tree exit_condition
+    = fold_build1_loc (expr.get_locus ().gcc_location (), TRUTH_NOT_EXPR,
+		       boolean_type_node, condition);
   tree exit_expr
-    = ctx->get_backend ()->exit_expression (condition, expr.get_locus ());
+    = ctx->get_backend ()->exit_expression (exit_condition, expr.get_locus ());
   ctx->add_statement (exit_expr);
 
   tree code_block_stmt

                 reply	other threads:[~2023-01-31 13:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131131608.CDC593854801@sourceware.org \
    --to=cohenarthur@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).