From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1923) id 6980F3858D28; Tue, 31 Jan 2023 15:34:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6980F3858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675179282; bh=YZSYK2fY6RSOObu0c7BgPesSEZWp+2VOcqSWDAG0qHM=; h=From:To:Subject:Date:From; b=jJdHQjjSD/F+wyLOBq3kV8wP+W60Vd0COiT1aMGpBFfMzPGNY94+sXL9/fjo9o5tS R9EXE24o+1n76Xy/e+Nz/NRW+YyuAW7vtnPlRYoyM75HwVrn9+apaJMFFhJKjmWzhs mTZjiDPXzSuklurPUcdRPJLEayzkdFW/YBmTWEYU= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Philipp Tomsich To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5581] PR target/108589 - Check REG_P for AARCH64_FUSE_ADDSUB_2REG_CONST1 X-Act-Checkin: gcc X-Git-Author: Philipp Tomsich X-Git-Refname: refs/heads/master X-Git-Oldrev: 2bb444787ed17a9e786f544cdf51ee2ac6779ab2 X-Git-Newrev: a39c6ec97906766ad65d15d4856fd41121ee7a45 Message-Id: <20230131153442.6980F3858D28@sourceware.org> Date: Tue, 31 Jan 2023 15:34:42 +0000 (GMT) List-Id: https://gcc.gnu.org/g:a39c6ec97906766ad65d15d4856fd41121ee7a45 commit r13-5581-ga39c6ec97906766ad65d15d4856fd41121ee7a45 Author: Philipp Tomsich Date: Mon Jan 30 23:40:26 2023 +0100 PR target/108589 - Check REG_P for AARCH64_FUSE_ADDSUB_2REG_CONST1 This adds a check for REG_P on SET_DEST for the new idiom recognizer for AARCH64_FUSE_ADDSUB_2REG_CONST1. The reported ICE is only observable with checking=rtl. Bootstrapped/regtested aarch64-linux, committed. PR target/108589 gcc/ChangeLog: * config/aarch64/aarch64.cc (aarch_macro_fusion_pair_p): Check REG_P on SET_DEST. gcc/testsuite/ChangeLog: * gcc.target/aarch64/pr108589.c: New test. Diff: --- gcc/config/aarch64/aarch64.cc | 1 + gcc/testsuite/gcc.target/aarch64/pr108589.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index 17c1e23e5b5..acc0cfe5f94 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -25704,6 +25704,7 @@ aarch_macro_fusion_pair_p (rtx_insn *prev, rtx_insn *curr) && CONST_INT_P (XEXP (curr_src, 1)) && INTVAL (XEXP (curr_src, 1)) == polarity && REG_P (XEXP (curr_src, 0)) + && REG_P (SET_DEST (prev_set)) && REGNO (SET_DEST (prev_set)) == REGNO (XEXP (curr_src, 0))) return true; } diff --git a/gcc/testsuite/gcc.target/aarch64/pr108589.c b/gcc/testsuite/gcc.target/aarch64/pr108589.c new file mode 100644 index 00000000000..861727f7268 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/pr108589.c @@ -0,0 +1,15 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target lp64 } */ +/* { dg-options "-Os -O2 -mtune=ampere1a -fno-split-wide-types" } */ + +int i; +__int128 j; +short s; + +void +foo (void) +{ + j -= i; + int l = i - __builtin_sub_overflow_p (0, 61680, s); + j -= __builtin_mul_overflow_p (i, l, 0); +}