public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5623] compare-elim: Fix an RTL checking failure
Date: Wed,  1 Feb 2023 09:54:08 +0000 (GMT)	[thread overview]
Message-ID: <20230201095408.14CF2385B51B@sourceware.org> (raw)

https://gcc.gnu.org/g:3cef9dca57ba70576dc387c40e600f00de5d55de

commit r13-5623-g3cef9dca57ba70576dc387c40e600f00de5d55de
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Feb 1 09:53:50 2023 +0000

    compare-elim: Fix an RTL checking failure
    
    find_flags_uses_in_insn used SET_SRC without first checking
    for a SET.  This showed up as an RTL checking failure in
    g++.dg/torture/pr90994.C on aarch64.
    
    gcc/
            * compare-elim.cc (find_flags_uses_in_insn): Guard use of SET_SRC.

Diff:
---
 gcc/compare-elim.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/compare-elim.cc b/gcc/compare-elim.cc
index 5cbd2c027b1..c59dc0cf5a5 100644
--- a/gcc/compare-elim.cc
+++ b/gcc/compare-elim.cc
@@ -254,7 +254,8 @@ find_flags_uses_in_insn (struct comparison *cmp, rtx_insn *insn)
 	x = PATTERN (insn);
 	if (GET_CODE (x) == PARALLEL)
 	  x = XVECEXP (x, 0, 0);
-	x = SET_SRC (x);
+	if (GET_CODE (x) == SET)
+	  x = SET_SRC (x);
 	if (GET_CODE (x) == IF_THEN_ELSE)
 	  x = XEXP (x, 0);
 	if (COMPARISON_P (x)

                 reply	other threads:[~2023-02-01  9:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230201095408.14CF2385B51B@sourceware.org \
    --to=rsandifo@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).