public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Martin Liska <marxin@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-5626] driver: fix -gz=none error message with missing zstd
Date: Wed,  1 Feb 2023 13:13:20 +0000 (GMT)	[thread overview]
Message-ID: <20230201131320.699553858D33@sourceware.org> (raw)

https://gcc.gnu.org/g:1d77bfdf11fb9d7f9fcce7ed8817fc2877b3ded2

commit r13-5626-g1d77bfdf11fb9d7f9fcce7ed8817fc2877b3ded2
Author: Martin Liska <mliska@suse.cz>
Date:   Fri Jan 27 14:56:31 2023 +0100

    driver: fix -gz=none error message with missing zstd
    
    We wrongly report:
    
    $ echo "int main () {}" | gcc -xc -gz=none -
    gcc: error: -gz=zstd is not supported in this configuration
    
    if zstd compression is not supported by binutils. We should emit the
    error message only if -gz=zstd.
    
            PR driver/108572
    
    gcc/ChangeLog:
    
            * gcc.cc (LINK_COMPRESS_DEBUG_SPEC): Report error only for
            -gz=zstd.

Diff:
---
 gcc/gcc.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/gcc.cc b/gcc/gcc.cc
index d8130024a8c..becc56051a8 100644
--- a/gcc/gcc.cc
+++ b/gcc/gcc.cc
@@ -842,7 +842,7 @@ proper position among the other output files.  */
 #define LINK_COMPRESS_DEBUG_SPEC \
 	" %{gz|gz=zlib:"  LD_COMPRESS_DEBUG_OPTION "=zlib}" \
 	" %{gz=none:"	  LD_COMPRESS_DEBUG_OPTION "=none}" \
-	" %{gz*:%e-gz=zstd is not supported in this configuration} " \
+	" %{gz=zstd:%e-gz=zstd is not supported in this configuration} " \
 	" %{gz=zlib-gnu:}" /* Ignore silently zlib-gnu option value.  */
 #elif HAVE_LD_COMPRESS_DEBUG == 2
 /* ELF gABI style and ZSTD.  */

                 reply	other threads:[~2023-02-01 13:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230201131320.699553858D33@sourceware.org \
    --to=marxin@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).