From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1734) id EF61A3858D33; Wed, 1 Feb 2023 13:31:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF61A3858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675258275; bh=eS514u+k6mtFaVZ2q4DBG8lI1Q+dYkU6ssdECmDMP58=; h=From:To:Subject:Date:From; b=VJPfAqpvHSBccLraOAkX7nTMcsL30w4JsIB+NrqeMd9G5pHGkfUWyJpD/bukCHrrI cggMLZjC4soyFk4uYgyia/E2nLyA34WE7iMkhVuetGdupdggeAbgKwLRppw+KPovyo YyH7zGgvFGVmMDiPVQZAY57eQUZIWwiqD+7eGtm4= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Marek Polacek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5627] c++: ICE with -Wlogical-op [PR107755] X-Act-Checkin: gcc X-Git-Author: Marek Polacek X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 1d77bfdf11fb9d7f9fcce7ed8817fc2877b3ded2 X-Git-Newrev: 5ce8961b46f050a96e8c542b34b1cf024ba95f1b Message-Id: <20230201133115.EF61A3858D33@sourceware.org> Date: Wed, 1 Feb 2023 13:31:15 +0000 (GMT) List-Id: https://gcc.gnu.org/g:5ce8961b46f050a96e8c542b34b1cf024ba95f1b commit r13-5627-g5ce8961b46f050a96e8c542b34b1cf024ba95f1b Author: Marek Polacek Date: Tue Jan 31 14:36:30 2023 -0500 c++: ICE with -Wlogical-op [PR107755] Here we crash in the middle end because warn_logical_operator calls build_range_check which calls various fold_* functions and those don't work too well when we're still processing template trees. For instance here we crash because we're converting a RECORD_TYPE to bool. At this point VIEW_CONVERT_EXPR(b) hasn't yet been converted to Foo::operator bool (&b). I was excited to fix this with instantiation_dependent_expression_p which can now be called from c-family/ as well, but the problem isn't that the expression is dependent. So, p_t_d it is. PR c++/107755 gcc/cp/ChangeLog: * call.cc (build_new_op): Don't call warn_logical_operator when processing a template. gcc/testsuite/ChangeLog: * g++.dg/warn/Wlogical-op-4.C: New test. Diff: --- gcc/cp/call.cc | 2 +- gcc/testsuite/g++.dg/warn/Wlogical-op-4.C | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc index 5715a7cd1de..f7c5d9da94b 100644 --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -7335,7 +7335,7 @@ build_new_op (const op_location_t &loc, enum tree_code code, int flags, case TRUTH_ORIF_EXPR: case TRUTH_AND_EXPR: case TRUTH_OR_EXPR: - if (complain & tf_warning) + if ((complain & tf_warning) && !processing_template_decl) warn_logical_operator (loc, code, boolean_type_node, code_orig_arg1, arg1, code_orig_arg2, arg2); diff --git a/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C b/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C new file mode 100644 index 00000000000..745c9117a3d --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C @@ -0,0 +1,23 @@ +// PR c++/107755 +// { dg-do compile } +// { dg-options "-Wlogical-op" } + +struct Foo +{ + operator bool() const { return false; } +}; + +bool a; +Foo b; + +template +static bool Bar() +{ + return (true && (false ? a : b)); + return (false || (false ? a : b)); +} + +bool Baz() +{ + return Bar(); +}