From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1011) id BEA253858401; Wed, 1 Feb 2023 14:27:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEA253858401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675261639; bh=VzXiveY0jNZ5pKhBgy5WuuqpXo72hmG2zlLcwsPznNs=; h=From:To:Subject:Date:From; b=MqTUcrXweycYT5a0KxqP7oNWIuqtkiwTXvsn/89Sa3u25XVPXlouJjfGj4WvhBDGa T9vHPkuhEF9gUG//V4a89xTYNeHsc0EtGgRXJlQhaBhcuYR99/hql/cpfHM2IS0LFj BtYScFjn2BIpzQjnbyRPhzqKGgBPdeAJtgnq8XGU= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Macleod To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5630] Ranger cache - always use range_from_dom when updating. X-Act-Checkin: gcc X-Git-Author: Andrew MacLeod X-Git-Refname: refs/heads/master X-Git-Oldrev: 78589691ee158e689fa9bb7dec1165da475ea634 X-Git-Newrev: 881bf8de9b07fb501d61ade8f521f1cc9dbe712e Message-Id: <20230201142719.BEA253858401@sourceware.org> Date: Wed, 1 Feb 2023 14:27:19 +0000 (GMT) List-Id: https://gcc.gnu.org/g:881bf8de9b07fb501d61ade8f521f1cc9dbe712e commit r13-5630-g881bf8de9b07fb501d61ade8f521f1cc9dbe712e Author: Andrew MacLeod Date: Tue Jan 10 13:40:56 2023 -0500 Ranger cache - always use range_from_dom when updating. When updating an existing range, if we dont query the dom tree, we can get the global range instead of a proper range on some incoming edges which cause the range to not be refined properly. PR tree-optimization/108356 gcc/ * gimple-range-cache.cc (ranger_cache::range_on_edge): Always do a search of the DOM tree for a range. gcc/testsuite/ * gcc.dg/pr108356.c: New. Diff: --- gcc/gimple-range-cache.cc | 2 +- gcc/testsuite/gcc.dg/pr108356.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc index a8202f0e895..20c444bc4f4 100644 --- a/gcc/gimple-range-cache.cc +++ b/gcc/gimple-range-cache.cc @@ -998,7 +998,7 @@ bool ranger_cache::range_on_edge (vrange &r, edge e, tree expr) { if (gimple_range_ssa_p (expr)) - return edge_range (r, e, expr, RFD_NONE); + return edge_range (r, e, expr, RFD_READ_ONLY); return get_tree_range (r, expr, NULL); } diff --git a/gcc/testsuite/gcc.dg/pr108356.c b/gcc/testsuite/gcc.dg/pr108356.c new file mode 100644 index 00000000000..1df6b278e45 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr108356.c @@ -0,0 +1,23 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-optimized" } */ + +char a; +static char c = 3; +char d; +void foo(); +short(b)(short e, short f) { return e + f; } +int main() { + unsigned g = 0; + if (c) + ; + else + foo(); + for (; g < 2; g = b(g, 2)) { + d = g ? 0 : a; + if (g) + c = 0; + } +} + + +/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */