public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-5653] RISC-V: Fix bug of TARGET_COMPUTE_MULTILIB implemented in riscv.
@ 2023-02-02 13:32 Kito Cheng
  0 siblings, 0 replies; only message in thread
From: Kito Cheng @ 2023-02-02 13:32 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:a02aacf55a35876ddc1e534778dc37fae29054f6

commit r13-5653-ga02aacf55a35876ddc1e534778dc37fae29054f6
Author: Jin Ma <jinma@linux.alibaba.com>
Date:   Thu Feb 2 19:46:04 2023 +0800

    RISC-V: Fix bug of TARGET_COMPUTE_MULTILIB implemented in riscv.
    
    MAX_MATCH_SCORE is not assigned anywhere except initialized to 0,
    causing BEST_MATCH_MULTI_LIB to always be 0 or -1, which will
    cause the result of TARGET_COMPUTE_MULTILIB hook to fail.
    
    gcc/ChangeLog:
    
            * common/config/riscv/riscv-common.cc (riscv_compute_multilib):
            Fix finding best match score.

Diff:
---
 gcc/common/config/riscv/riscv-common.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
index 616e2f897b9..787674003cb 100644
--- a/gcc/common/config/riscv/riscv-common.cc
+++ b/gcc/common/config/riscv/riscv-common.cc
@@ -1700,7 +1700,10 @@ riscv_compute_multilib (
 
       /* Record highest match score multi-lib setting.  */
       if (match_score > max_match_score)
-	best_match_multi_lib = i;
+	{
+	  best_match_multi_lib = i;
+	  max_match_score = match_score;
+	}
     }
 
   if (best_match_multi_lib == -1)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-02 13:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 13:32 [gcc r13-5653] RISC-V: Fix bug of TARGET_COMPUTE_MULTILIB implemented in riscv Kito Cheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).