public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Tobias Burnus <burnus@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5679] libgomp: enable reverse offload for AMDGCN Date: Fri, 3 Feb 2023 07:34:16 +0000 (GMT) [thread overview] Message-ID: <20230203073416.97D2F3861872@sourceware.org> (raw) https://gcc.gnu.org/g:f84fdb134dec02f68fd9a39a58e726023470e537 commit r13-5679-gf84fdb134dec02f68fd9a39a58e726023470e537 Author: Tobias Burnus <tobias@codesourcery.com> Date: Fri Feb 3 08:33:17 2023 +0100 libgomp: enable reverse offload for AMDGCN libgomp/ChangeLog: * libgomp.texi (5.0 Impl. Status, gcn specifics): Update for reverse offload. * plugin/plugin-gcn.c (GOMP_OFFLOAD_get_num_devices): Accept reverse-offload requirement. Diff: --- libgomp/libgomp.texi | 13 ++++++++----- libgomp/plugin/plugin-gcn.c | 3 ++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi index 1f84b050eb2..698ae330942 100644 --- a/libgomp/libgomp.texi +++ b/libgomp/libgomp.texi @@ -227,8 +227,7 @@ The OpenMP 4.5 specification is fully supported. @item @code{allocate} directive @tab N @tab @item @code{allocate} clause @tab P @tab Initial support @item @code{use_device_addr} clause on @code{target data} @tab Y @tab -@item @code{ancestor} modifier on @code{device} clause - @tab Y @tab Host fallback with GCN devices +@item @code{ancestor} modifier on @code{device} clause @tab Y @tab @item Implicit declare target directive @tab Y @tab @item Discontiguous array section with @code{target update} construct @tab N @tab @@ -4455,9 +4454,13 @@ The implementation remark: @item I/O within OpenMP target regions and OpenACC parallel/kernels is supported using the C library @code{printf} functions and the Fortran @code{print}/@code{write} statements. -@item OpenMP code that has a requires directive with @code{unified_address}, - @code{unified_shared_memory} or @code{reverse_offload} will remove - any GCN device from the list of available devices (``host fallback''). +@item Reverse offload (i.e. @code{target} regions with + @code{device(ancestor:1)}) are processed serially per @code{target} region + such that the next reverse offload region is only executed after the previous + one returned. +@item OpenMP code that has a requires directive with @code{unified_address} or + @code{unified_shared_memory} will remove any GCN device from the list of + available devices (``host fallback''). @end itemize diff --git a/libgomp/plugin/plugin-gcn.c b/libgomp/plugin/plugin-gcn.c index a7b35059ab3..11ce6b0fa8d 100644 --- a/libgomp/plugin/plugin-gcn.c +++ b/libgomp/plugin/plugin-gcn.c @@ -3262,7 +3262,8 @@ GOMP_OFFLOAD_get_num_devices (unsigned int omp_requires_mask) return 0; /* Return -1 if no omp_requires_mask cannot be fulfilled but devices were present. */ - if (hsa_context.agent_count > 0 && omp_requires_mask != 0) + if (hsa_context.agent_count > 0 + && (omp_requires_mask & ~GOMP_REQUIRES_REVERSE_OFFLOAD) != 0) return -1; return hsa_context.agent_count; }
reply other threads:[~2023-02-03 7:34 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230203073416.97D2F3861872@sourceware.org \ --to=burnus@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).