public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Patrick Palka <ppalka@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5684] c++: unexpected ADDR_EXPR after overload set pruning [PR107461] Date: Fri, 3 Feb 2023 14:41:19 +0000 (GMT) [thread overview] Message-ID: <20230203144119.624C33858D20@sourceware.org> (raw) https://gcc.gnu.org/g:59e0376f607805ef9b67fd7b0a4a3084ab3571a5 commit r13-5684-g59e0376f607805ef9b67fd7b0a4a3084ab3571a5 Author: Patrick Palka <ppalka@redhat.com> Date: Fri Feb 3 09:41:10 2023 -0500 c++: unexpected ADDR_EXPR after overload set pruning [PR107461] Here the ahead-of-time overload set pruning in finish_call_expr is unintentionally returning a CALL_EXPR whose (pruned) callee is wrapped in an ADDR_EXPR, despite the original callee not being wrapped in an ADDR_EXPR. This ends up causing a bogus declaration mismatch error in the below testcase because the call to min in #1 gets expressed as a CALL_EXPR of ADDR_EXPR of FUNCTION_DECL, whereas the level-lowered call to min in #2 gets expressed instead as a CALL_EXPR of FUNCTION_DECL. This patch fixes this by stripping the spurious ADDR_EXPR appropriately. Thus the first call to min now also gets expressed as a CALL_EXPR of FUNCTION_DECL, matching the behavior before r12-6075-g2decd2cabe5a4f. PR c++/107461 gcc/cp/ChangeLog: * semantics.cc (finish_call_expr): Strip ADDR_EXPR from the selected callee during overload set pruning. gcc/testsuite/ChangeLog: * g++.dg/template/call9.C: New test. Diff: --- gcc/cp/semantics.cc | 15 ++++++++++----- gcc/testsuite/g++.dg/template/call9.C | 26 ++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc index 1656d02d6d1..c2df0b69b30 100644 --- a/gcc/cp/semantics.cc +++ b/gcc/cp/semantics.cc @@ -2957,13 +2957,18 @@ finish_call_expr (tree fn, vec<tree, va_gc> **args, bool disallow_virtual, if (TREE_CODE (result) == CALL_EXPR && really_overloaded_fn (orig_fn)) { - orig_fn = CALL_EXPR_FN (result); - if (TREE_CODE (orig_fn) == COMPONENT_REF) + tree sel_fn = CALL_EXPR_FN (result); + if (TREE_CODE (sel_fn) == COMPONENT_REF) { /* The non-dependent result of build_new_method_call. */ - orig_fn = TREE_OPERAND (orig_fn, 1); - gcc_assert (BASELINK_P (orig_fn)); - } + sel_fn = TREE_OPERAND (sel_fn, 1); + gcc_assert (BASELINK_P (sel_fn)); + } + else if (TREE_CODE (sel_fn) == ADDR_EXPR) + /* Our original callee wasn't wrapped in an ADDR_EXPR, + so strip this ADDR_EXPR added by build_over_call. */ + sel_fn = TREE_OPERAND (sel_fn, 0); + orig_fn = sel_fn; } result = build_call_vec (TREE_TYPE (result), orig_fn, orig_args); diff --git a/gcc/testsuite/g++.dg/template/call9.C b/gcc/testsuite/g++.dg/template/call9.C new file mode 100644 index 00000000000..6bdfd932582 --- /dev/null +++ b/gcc/testsuite/g++.dg/template/call9.C @@ -0,0 +1,26 @@ +// PR c++/107461 +// { dg-do compile { target c++11 } } + +template<class T> +constexpr T min(T t0, T t1) { + return t0 < t1 ? t0 : t1; +} + +template<int MAX> +struct Matrix; + +template<int MAXOP, int other_MAXOP> +Matrix<min(MAXOP, other_MAXOP)> +operator+(Matrix<MAXOP> const& lhs, Matrix<other_MAXOP> const& rhs); // #1 + +template<int MAX> +struct Matrix { + template<int MAXOP, int other_MAXOP> + friend Matrix<min(MAXOP, other_MAXOP)> + operator+(Matrix<MAXOP> const& lhs, Matrix<other_MAXOP> const& rhs); // #2 +}; + +int main() { + Matrix<1> a; + a+a; +}
reply other threads:[~2023-02-03 14:41 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230203144119.624C33858D20@sourceware.org \ --to=ppalka@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).