From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1643) id A7CE33858C36; Tue, 7 Feb 2023 17:56:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7CE33858C36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675792591; bh=AyvCR5DVj1hECckWyCY9NXRAZ1uVKUw+/l3UYTNfXRI=; h=From:To:Subject:Date:From; b=MbtpB0Ij/KmHUpBviR/xwTOAjr8IbPVLU4gPjytgUM3Yz4snc26WP6hxNe+omdlCR pxClInicG0cOVk1D0lmWjkB/Nd9mLvdtCMJ5apORSJzfBnKhKgNe/RDWVAOrtL6Th7 tDuHeGw18e1U7aNkDkHznQc15sbWfd2bWKnxKCkE= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Thomas Schwinge To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/rust/master] gccrs: Remove bad error message on checking function arguments X-Act-Checkin: gcc X-Git-Author: Philip Herron X-Git-Refname: refs/heads/devel/rust/master X-Git-Oldrev: aff069dfb1fb1dcd785d5af68373d83289d62c72 X-Git-Newrev: 1b0794c172c4e60ee4cd7f2fd3a2426997b1d0a1 Message-Id: <20230207175631.A7CE33858C36@sourceware.org> Date: Tue, 7 Feb 2023 17:56:31 +0000 (GMT) List-Id: https://gcc.gnu.org/g:1b0794c172c4e60ee4cd7f2fd3a2426997b1d0a1 commit 1b0794c172c4e60ee4cd7f2fd3a2426997b1d0a1 Author: Philip Herron Date: Sat Feb 4 23:02:31 2023 +0000 gccrs: Remove bad error message on checking function arguments Signed-off-by: Philip Herron gcc/rust/ChangeLog: * typecheck/rust-tyty-call.cc (TypeCheckCallExpr::visit): remove error message gcc/testsuite/ChangeLog: * rust/compile/func3.rs: update test case Diff: --- gcc/rust/typecheck/rust-tyty-call.cc | 5 ----- gcc/testsuite/rust/compile/func3.rs | 1 - 2 files changed, 6 deletions(-) diff --git a/gcc/rust/typecheck/rust-tyty-call.cc b/gcc/rust/typecheck/rust-tyty-call.cc index 6ff0113e66b..4010c6079cc 100644 --- a/gcc/rust/typecheck/rust-tyty-call.cc +++ b/gcc/rust/typecheck/rust-tyty-call.cc @@ -140,8 +140,6 @@ TypeCheckCallExpr::visit (FnType &type) argument->get_locus ()); if (resolved_argument_type->get_kind () == TyTy::TypeKind::ERROR) { - rust_error_at (argument->get_locus (), - "Type Resolution failure on parameter"); return; } } @@ -193,8 +191,6 @@ TypeCheckCallExpr::visit (FnPtr &type) TyWithLocation (argument_expr_tyty, arg_locus), argument->get_locus ()); if (resolved_argument_type->get_kind () == TyTy::TypeKind::ERROR) { - rust_error_at (argument->get_locus (), - "Type Resolution failure on parameter"); return; } @@ -301,7 +297,6 @@ TypeCheckMethodCallExpr::check (FnType &type) TyWithLocation (argument_expr_tyty, arg_locus), arg_locus); if (resolved_argument_type->get_kind () == TyTy::TypeKind::ERROR) { - rust_error_at (arg_locus, "Type Resolution failure on parameter"); return new ErrorType (type.get_ref ()); } diff --git a/gcc/testsuite/rust/compile/func3.rs b/gcc/testsuite/rust/compile/func3.rs index 2a329476118..002e5c90ab5 100644 --- a/gcc/testsuite/rust/compile/func3.rs +++ b/gcc/testsuite/rust/compile/func3.rs @@ -5,5 +5,4 @@ fn test(a: i32, b: i32) -> i32 { fn main() { let a = test(1, true); // { dg-error "expected .i32. got .bool." "" { target *-*-* } .-1 } - // { dg-error "Type Resolution failure on parameter" "" { target *-*-* } .-2 } }