From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id 670D93858C50; Wed, 8 Feb 2023 18:15:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 670D93858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675880142; bh=3uYZOfrcHhm1zXIDmu1wIpGCOXe/751/D+nEx+VaBuo=; h=From:To:Subject:Date:From; b=ydkPb0Kk8S6VWjpHygfj5sIKhBi+mp0OfJQer+kvNUOC4+L0CvkJ+AKV1KXZOp7ww YZYcdAHcM61gAzmLCKG/rK6C/LJ6TWIk3NABqaUZAAd44RmkCX3epqpXhnV4BTsDL8 7L36FopI2gCk0V9XljhWvm8xeR0IPu5uu2/diNA8= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5743] Fortran: error handling of global entity appearing in COMMON block [PR103259] X-Act-Checkin: gcc X-Git-Author: Steve Kargl X-Git-Refname: refs/heads/master X-Git-Oldrev: 6ad1c1027628f094260037536f6b6fcdb63b5add X-Git-Newrev: 7e9f20f5517429cfaadec14d6b04705e59078565 Message-Id: <20230208181542.670D93858C50@sourceware.org> Date: Wed, 8 Feb 2023 18:15:42 +0000 (GMT) List-Id: https://gcc.gnu.org/g:7e9f20f5517429cfaadec14d6b04705e59078565 commit r13-5743-g7e9f20f5517429cfaadec14d6b04705e59078565 Author: Steve Kargl Date: Tue Feb 7 20:18:42 2023 +0100 Fortran: error handling of global entity appearing in COMMON block [PR103259] gcc/fortran/ChangeLog: PR fortran/103259 * resolve.cc (resolve_common_vars): Avoid NULL pointer dereference when a symbol's location is not set. gcc/testsuite/ChangeLog: PR fortran/103259 * gfortran.dg/pr103259.f90: New test. Diff: --- gcc/fortran/resolve.cc | 12 +++++++++--- gcc/testsuite/gfortran.dg/pr103259.f90 | 11 +++++++++++ 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 100b2382e22..549916c2b53 100644 --- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -953,9 +953,15 @@ resolve_common_vars (gfc_common_head *common_block, bool named_common) { gsym = gfc_find_gsymbol (gfc_gsym_root, csym->name); if (gsym && (gsym->type == GSYM_MODULE || gsym->type == GSYM_PROGRAM)) - gfc_error_now ("Global entity %qs at %L cannot appear in a " - "COMMON block at %L", gsym->name, - &gsym->where, &csym->common_block->where); + { + if (csym->common_block) + gfc_error_now ("Global entity %qs at %L cannot appear in a " + "COMMON block at %L", gsym->name, + &gsym->where, &csym->common_block->where); + else + gfc_error_now ("Global entity %qs at %L cannot appear in a " + "COMMON block", gsym->name, &gsym->where); + } /* gfc_add_in_common may have been called before, but the reported errors have been ignored to continue parsing. diff --git a/gcc/testsuite/gfortran.dg/pr103259.f90 b/gcc/testsuite/gfortran.dg/pr103259.f90 new file mode 100644 index 00000000000..f78ff26180e --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr103259.f90 @@ -0,0 +1,11 @@ +! { dg-do compile } +! PR fortran/103259 - ICE in resolve_common_vars +! Contributed by G.Steinmetz + +module m + integer :: p + common /c/ p +end +program p ! { dg-error "cannot appear in a COMMON block" } + use m ! { dg-error "is also the name of the current program unit" } +end