From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 9C0823858C5F; Thu, 9 Feb 2023 15:07:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C0823858C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675955228; bh=0zLnFFtWvVYpxds5RY4y6xq6iqHNdDRk3ZGnoaz69/4=; h=From:To:Subject:Date:From; b=GVOVVMfkWsfV6cI98wPrzJzOxCKw9YzoFj2uJ9KvhDCTW6QFyMRVM2PcvhuDLjAN2 o/82/hI2cy8iYfrWnD3avO9YsDwAelbRsm3i987FO6wEC8qSRhVzI+KNZVHbbbXVKW 7Ei/w+T1SuC1W5XwnqfhIHY3py1N0gTlXZ14X5jg= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-5757] match.pd: When simplifying BFR of an insert, require a mode precision integral type [PR108688] X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/master X-Git-Oldrev: ac2949574da9a668daad421d7edb79f172f73c6f X-Git-Newrev: 44f308e59bfa0f93ae05b17e257d8563c12399fd Message-Id: <20230209150708.9C0823858C5F@sourceware.org> Date: Thu, 9 Feb 2023 15:07:08 +0000 (GMT) List-Id: https://gcc.gnu.org/g:44f308e59bfa0f93ae05b17e257d8563c12399fd commit r13-5757-g44f308e59bfa0f93ae05b17e257d8563c12399fd Author: Andrew Pinski Date: Thu Feb 9 16:03:54 2023 +0100 match.pd: When simplifying BFR of an insert, require a mode precision integral type [PR108688] The same problem as PR 88739 has crept in but this time in match.pd when simplifying bit_field_ref of an bit_insert. That is we are generating a BIT_FIELD_REF of a non-mode-precision integral type. PR tree-optimization/108688 * match.pd (bit_field_ref [bit_insert]): Avoid generating BIT_FIELD_REFs of non-mode-precision integral operands. * gcc.c-torture/compile/pr108688-1.c: New test. Diff: --- gcc/match.pd | 4 +++- gcc/testsuite/gcc.c-torture/compile/pr108688-1.c | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/gcc/match.pd b/gcc/match.pd index f605b798c44..73e5053d155 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -7474,7 +7474,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) isize = tree_to_uhwi (TYPE_SIZE (TREE_TYPE (@1))); } (switch - (if (wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos)) + (if ((!INTEGRAL_TYPE_P (TREE_TYPE (@1)) + || type_has_mode_precision_p (TREE_TYPE (@1))) + && wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos)) && wi::leu_p (wi::to_wide (@rpos) + wi::to_wide (@rsize), wi::to_wide (@ipos) + isize)) (BIT_FIELD_REF @1 @rsize { wide_int_to_tree (bitsizetype, diff --git a/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c b/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c new file mode 100644 index 00000000000..43d782d62bd --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c @@ -0,0 +1,15 @@ + + +union U { signed int d : 7; signed int e : 2; } u; +int a, b; + +void +foo (void) +{ + for (int i = 0; i < 64; i++) + { + u.d = a; + u.e ^= b; + } +} +