public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Filip Kastl <pheeck@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/pheeck/heads/sccp)] analyzer: Use __builtin_alloca in gcc.dg/analyzer/call-summaries-2.c
Date: Wed, 15 Feb 2023 10:22:23 +0000 (GMT)	[thread overview]
Message-ID: <20230215102223.35109385841C@sourceware.org> (raw)

https://gcc.gnu.org/g:3376448cee3e8f1c9b47c07886fe756c606f66b8

commit 3376448cee3e8f1c9b47c07886fe756c606f66b8
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Wed Nov 23 21:54:26 2022 +0100

    analyzer: Use __builtin_alloca in gcc.dg/analyzer/call-summaries-2.c
    
    gcc.dg/analyzer/call-summaries-2.c currently FAILs on Solaris:
    
    FAIL: gcc.dg/analyzer/call-summaries-2.c (test for excess errors)
    
    Excess errors:
    /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c:468:12:
    warning: implicit declaration of function 'alloca' [-Wimplicit-function-declaration]
    /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c:468:12:
    warning: incompatible implicit declaration of built-in function 'alloca' [-Wbuiltin-declaration-mismatch]
    
    alloca is only declared in <alloca.h>, which isn't included indirectly
    anywhere.  To avoid this, I switched the test to use __builtin_alloca
    instead, following the vast majority of analyzer tests that use alloca.
    
    Tested no i386-pc-solaris2.11, sparc-sun-solaris2.11, and
    x86_64-pc-linux-gnu.
    
    2022-11-23  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
            gcc/testsuite:
            * gcc.dg/analyzer/call-summaries-2.c (uses_alloca): Use
            __builtin_alloca instead of alloca.

Diff:
---
 gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c b/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c
index 85cece72b34..953cbd32f5a 100644
--- a/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c
+++ b/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c
@@ -465,7 +465,7 @@ int test_returns_external_result (void)
 
 int uses_alloca (int i)
 {
-  int *p = alloca (sizeof (int));
+  int *p = __builtin_alloca (sizeof (int));
   *p = i;
   return *p;
 }

                 reply	other threads:[~2023-02-15 10:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215102223.35109385841C@sourceware.org \
    --to=pheeck@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).