public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Ondrej Kubanek <kubaneko@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/kubaneko/heads/histogram)] messed with logarithms
Date: Thu, 16 Feb 2023 16:28:06 +0000 (GMT)	[thread overview]
Message-ID: <20230216162806.2E158385B525@sourceware.org> (raw)

https://gcc.gnu.org/g:fdb7878232b77209916d5b5813af3b922edccfdb

commit fdb7878232b77209916d5b5813af3b922edccfdb
Author: kubaneko <kubanek0ondrej@gmail.com>
Date:   Tue Nov 1 17:48:30 2022 +0000

    messed with logarithms

Diff:
---
 libgcc/libgcov-profiler.c | 51 +++++++++++++++++++++++++----------------------
 1 file changed, 27 insertions(+), 24 deletions(-)

diff --git a/libgcc/libgcov-profiler.c b/libgcc/libgcov-profiler.c
index f150d75fee1..8088f3d647a 100644
--- a/libgcc/libgcov-profiler.c
+++ b/libgcc/libgcov-profiler.c
@@ -32,6 +32,28 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
  * otherwise we take its logarithm and increment corresponding counter
  */
 
+/* For convenience, define 0 -> word_size.  */
+static inline int
+clz_hwi (gcov_type x)
+{
+  if (x == 0)
+    return 64;
+# if HOST_BITS_PER_WIDE_INT == HOST_BITS_PER_LONG
+  return __builtin_clzl (x);
+# elif HOST_BITS_PER_WIDE_INT == HOST_BITS_PER_LONGLONG
+  return __builtin_clzll (x);
+# else
+  return __builtin_clz (x);
+# endif
+}
+
+static inline int
+floor_log2 (gcov_type x)
+{
+  return 63 - clz_hwi (x);
+}
+
+
 void
 __gcov_histogram_profiler (gcov_type *counters, gcov_type value)
 {
@@ -39,19 +61,10 @@ __gcov_histogram_profiler (gcov_type *counters, gcov_type value)
     counters[value]++;
   }else{
     gcc_assert(value>0);
-    int pow2 = 3;
-    while (1 << pow2 <= value || 1 << pow2 > 1 << (pow2 + 1)){
-      ++pow2;
-    }
-    // pow2 is first bigger power of 2
-    // we increment closer power of 2
-    if ((1<<pow2+1<<(pow2-1))>>1<value){
-      counters[6+(pow2-3)]++;
-    }
-    else{
-      counters[7+(pow2-3)]++;
-    }
+    int pow2=floor_log2(value);
+    counters[pow2+5]++;
   }
+  printf("\n %d %d \n", floor_log2(value), value);
 }
 
 #endif
@@ -71,18 +84,8 @@ __gcov_histogram_profiler_atomic (gcov_type *counters, gcov_type value)
     __atomic_fetch_add (&counters[value], 1, __ATOMIC_RELAXED);
   }else{
     gcc_assert(value>0);
-    int pow2 = 3;
-    while (1 << pow2 <= value || 1 << pow2 > 1 << (pow2 + 1)){
-      ++pow2;
-    }
-    // pow2 is first bigger power of 2
-    // we increment closer power of 2
-    if ((1<<pow2+1<<(pow2-1))>>1<value){
-      __atomic_fetch_add (&counters[6+(pow2-3)], 1, __ATOMIC_RELAXED);
-    }
-    else{
-      __atomic_fetch_add (&counters[7+(pow2-3)], 1, __ATOMIC_RELAXED);
-    }
+    int pow2=floor_log2(value);
+    __atomic_fetch_add (&counters[pow2+5], 1, __ATOMIC_RELAXED);
   }
 }

             reply	other threads:[~2023-02-16 16:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 16:28 Ondrej Kubanek [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-23 23:21 Ondrej Kubanek
2022-11-22 13:13 Ondrej Kubanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216162806.2E158385B525@sourceware.org \
    --to=kubaneko@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).