public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Rainer Orth <ro@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-6115] contrib: Fix make_sunver.pl warning
Date: Fri, 17 Feb 2023 12:33:54 +0000 (GMT)	[thread overview]
Message-ID: <20230217123354.1053E3858C31@sourceware.org> (raw)

https://gcc.gnu.org/g:ae2c1d0a9dc33f4c309a589d9f68fcd31206500e

commit r13-6115-gae2c1d0a9dc33f4c309a589d9f68fcd31206500e
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Fri Feb 17 13:33:25 2023 +0100

    contrib: Fix make_sunver.pl warning
    
    Petr informed me that perl 5.32 bundled with Solaris 11.4 warns about
    make_sunver.pl:
    
    Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/^([ \t]*){ <-- HERE $/ at /vol/gcc/src/hg/master/local/libgomp/../contrib/make_sunver.pl line 216.
    
    I didn't notice since I'm using a common installation of perl 5.12
    across Solaris versions that doesn't show that warning.
    
    His patch fixes the issue.  Tested on Solaris 11.3 (perl 5.12) and 11.4
    (perl 5.32).
    
    2023-01-20  Petr Sumbera  <petr.sumbera@oracle.com>
    
            contrib:
            * make_sunver.pl: Escape brace.

Diff:
---
 contrib/make_sunver.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/make_sunver.pl b/contrib/make_sunver.pl
index 8a90b1fea0d..32e639ed873 100644
--- a/contrib/make_sunver.pl
+++ b/contrib/make_sunver.pl
@@ -213,7 +213,7 @@ while (<F>) {
     if (/^[ \t]*$/) { print; next; }
 
     # Lines of the form '{'
-    if (/^([ \t]*){$/) {
+    if (/^([ \t]*)\{$/) {
 	if ($in_extern) {
 	    print "$1##{\n";
 	} else {

                 reply	other threads:[~2023-02-17 12:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217123354.1053E3858C31@sourceware.org \
    --to=ro@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).