From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id A74013858C83; Wed, 22 Feb 2023 17:56:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A74013858C83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677088576; bh=R7IDZK1O9WyELEaX19/ZyHbOTLzyGupD67ogTywC1x8=; h=From:To:Subject:Date:From; b=gRXyhjc44OqJvs+qbTJa2Wnk11gqjHcV7GJ41wIqg0LgWVF/YIJLoBfbY0EM9kcXx 8KK078IY+nXPXoaPrfMDlo3TQo/KSjQeqHiQ9becIwKrNJGWBoxdsAf+Km+eiq2paz nWfj32mAYzJFLSqfLGEuiox+8RuESyPcdNggpHj4= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6289] Fortran: reject invalid CHARACTER length of derived type components [PR96024] X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/master X-Git-Oldrev: 5344482c4d3ae0618fa8f5ed38f8309db43fdb82 X-Git-Newrev: 31303c9b5bab200754cdb7ef8cd91ae4918f3018 Message-Id: <20230222175616.A74013858C83@sourceware.org> Date: Wed, 22 Feb 2023 17:56:16 +0000 (GMT) List-Id: https://gcc.gnu.org/g:31303c9b5bab200754cdb7ef8cd91ae4918f3018 commit r13-6289-g31303c9b5bab200754cdb7ef8cd91ae4918f3018 Author: Harald Anlauf Date: Tue Feb 21 22:06:33 2023 +0100 Fortran: reject invalid CHARACTER length of derived type components [PR96024] gcc/fortran/ChangeLog: PR fortran/96024 * resolve.cc (resolve_component): The type of a CHARACTER length expression must be INTEGER. gcc/testsuite/ChangeLog: PR fortran/96024 * gfortran.dg/pr96024.f90: New test. Diff: --- gcc/fortran/resolve.cc | 13 +++++++++++++ gcc/testsuite/gfortran.dg/pr96024.f90 | 11 +++++++++++ 2 files changed, 24 insertions(+) diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 427f901a438..2780c82c798 100644 --- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -14892,6 +14892,19 @@ resolve_component (gfc_component *c, gfc_symbol *sym) c->ts.u.cl->length ? &c->ts.u.cl->length->where : &c->loc); return false; } + + if (c->ts.u.cl->length && c->ts.u.cl->length->ts.type != BT_INTEGER) + { + if (!c->ts.u.cl->length->error) + { + gfc_error ("Character length expression of component %qs at %L " + "must be of INTEGER type, found %s", + c->name, &c->ts.u.cl->length->where, + gfc_basic_typename (c->ts.u.cl->length->ts.type)); + c->ts.u.cl->length->error = 1; + } + return false; + } } if (c->ts.type == BT_CHARACTER && c->ts.deferred diff --git a/gcc/testsuite/gfortran.dg/pr96024.f90 b/gcc/testsuite/gfortran.dg/pr96024.f90 new file mode 100644 index 00000000000..2c914a997f2 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr96024.f90 @@ -0,0 +1,11 @@ +! { dg-do compile } +! PR fortran/96024 - ICE in mio_name_expr_t +! Contributed by G.Steinmetz + +module m + implicit none + type t + character(char(1)) :: a ! { dg-error "must be of INTEGER type" } + end type + type(t) :: z = t('a') +end