From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2140) id 833D83857C45; Thu, 23 Feb 2023 14:26:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 833D83857C45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677162384; bh=JykbrwkzuQ5vsYir1iLo7zRpN7+ZMmP/YgK/Wq9HbCY=; h=From:To:Subject:Date:From; b=OyPSoNlsE+83taSaVx7anDmHT2wdfEZEBlbG+/raHIYRmUQ8BhC3ufKotA78u7RIt 2TvHSRZeaOWB48tbsfYzCBp9EzIqrrVejKCGg2v5OCbMPg755FeXoVSzSEJ8J/JieG evLlFMACOl4F4I0z8xNcCnAYOcCXMDOyj4Jt2Zz4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandre Oliva To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods X-Act-Checkin: gcc X-Git-Author: Alexandre Oliva X-Git-Refname: refs/users/aoliva/heads/testme X-Git-Oldrev: 9bcdac23e29abd56819b15863a34f4dd9d2b574f X-Git-Newrev: d1500a90fa9a3f56a7275206a61f622c1ca4abeb Message-Id: <20230223142624.833D83857C45@sourceware.org> Date: Thu, 23 Feb 2023 14:26:24 +0000 (GMT) List-Id: https://gcc.gnu.org/g:d1500a90fa9a3f56a7275206a61f622c1ca4abeb commit d1500a90fa9a3f56a7275206a61f622c1ca4abeb Author: Alexandre Oliva Date: Thu Feb 23 11:01:30 2023 -0300 [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets that use the AAPCS variant. ARM is the only target that overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way the clash between AAPCS and C++ Modules design should be resolved, but currently it favors AAPCS and thus the test fails, so skip it on arm_eabi. for gcc/testsuite/ChangeLog PR c++/105224 * g++.dg/modules/virt-2_a.C: Skip on arm_eabi. Diff: --- gcc/testsuite/g++.dg/modules/virt-2_a.C | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C b/gcc/testsuite/g++.dg/modules/virt-2_a.C index 580552be5a0..8fa42d97d72 100644 --- a/gcc/testsuite/g++.dg/modules/virt-2_a.C +++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C @@ -1,4 +1,6 @@ -// { dg-module-do run } +// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE, +// in a way that invalidates this test. +// { dg-module-do run { target { ! arm_eabi } } } // { dg-additional-options -fmodules-ts } export module foo; // { dg-module-cmi foo }