From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id BE2493858C5E; Thu, 23 Feb 2023 14:57:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE2493858C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677164227; bh=tMCE0Y+2sY2XH9pKAzg8UJOwmu50N3iW3RCQr+aSds0=; h=From:To:Subject:Date:From; b=e4WeYlngKO4AgCJF6/v9MedWcPfZG9IJKgokhEmZmRGGsfxjeWtI8OeOsr6DWCCSL 3SRb0BF/QB39IwPN9713tLNFOmpQPURist3Qo+ymqSMl/I5+t6Mn/jyCRH6VZw960y 1QJoi97i8fOrDI2bJV2DL+PCW7M35oYoGH9LNqdc= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6305] Fix memory leak in PTA X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 9f9a7095d910379cd86ac45f81c79b363f859996 X-Git-Newrev: 426b0ae103894d1f1bd82e5f049ff8a53bd82a8d Message-Id: <20230223145707.BE2493858C5E@sourceware.org> Date: Thu, 23 Feb 2023 14:57:07 +0000 (GMT) List-Id: https://gcc.gnu.org/g:426b0ae103894d1f1bd82e5f049ff8a53bd82a8d commit r13-6305-g426b0ae103894d1f1bd82e5f049ff8a53bd82a8d Author: Richard Biener Date: Thu Feb 23 14:09:04 2023 +0100 Fix memory leak in PTA When handle_lhs_call calls .create on the passed in vector it leaks any previous allocated storage. Avoid doing that and instead rely on the caller for memory management, just truncate the vector. * tree-ssa-structalias.cc (handle_lhs_call): Do not re-create rhsc, only truncate it. Diff: --- gcc/tree-ssa-structalias.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/tree-ssa-structalias.cc b/gcc/tree-ssa-structalias.cc index 2ed32de06ed..07e0fd6827a 100644 --- a/gcc/tree-ssa-structalias.cc +++ b/gcc/tree-ssa-structalias.cc @@ -4408,17 +4408,17 @@ handle_lhs_call (gcall *stmt, tree lhs, int flags, vec &rhsc, && (flags & ERF_RETURN_ARG_MASK) < gimple_call_num_args (stmt)) { tree arg; - rhsc.create (0); + rhsc.truncate (0); arg = gimple_call_arg (stmt, flags & ERF_RETURN_ARG_MASK); get_constraint_for (arg, &rhsc); process_all_all_constraints (lhsc, rhsc); - rhsc.release (); + rhsc.truncate (0); } else if (flags & ERF_NOALIAS) { varinfo_t vi; struct constraint_expr tmpc; - rhsc.create (0); + rhsc.truncate (0); vi = make_heapvar ("HEAP", true); /* We are marking allocated storage local, we deal with it becoming global by escaping and setting of vars_contains_escaped_heap. */ @@ -4435,7 +4435,7 @@ handle_lhs_call (gcall *stmt, tree lhs, int flags, vec &rhsc, tmpc.type = ADDRESSOF; rhsc.safe_push (tmpc); process_all_all_constraints (lhsc, rhsc); - rhsc.release (); + rhsc.truncate (0); } else process_all_all_constraints (lhsc, rhsc);