From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2140) id DCDEB385840F; Fri, 24 Feb 2023 14:41:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCDEB385840F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677249668; bh=c/B+HgDayKbQuWJTV3+hQeZEonugwuuRaUvjWozlqdU=; h=From:To:Subject:Date:From; b=nQsB50ToN+yRCZl3YDC5xUrDguUGa7g9nQVI2GgEJSDW3efJjTVGdJCsmnv4zIRrg 5bKcc+FzYOer45YZ1zouySwzSjf+mjnrT8BLrAWvpM4BZ13eb8HpSIunCpXNhys5yJ PKGuGSfNqg91ZzlZdCZkl2DpzkkKyNRISVoTl+Kw= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Alexandre Oliva To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6329] [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods X-Act-Checkin: gcc X-Git-Author: Alexandre Oliva X-Git-Refname: refs/heads/master X-Git-Oldrev: 8520132bc362d5f915eb1cb20038492e37b3cf88 X-Git-Newrev: 3d1d3ece9bc5a1baa2feb4bf231b709c097b8434 Message-Id: <20230224144108.DCDEB385840F@sourceware.org> Date: Fri, 24 Feb 2023 14:41:08 +0000 (GMT) List-Id: https://gcc.gnu.org/g:3d1d3ece9bc5a1baa2feb4bf231b709c097b8434 commit r13-6329-g3d1d3ece9bc5a1baa2feb4bf231b709c097b8434 Author: Alexandre Oliva Date: Fri Feb 24 11:31:05 2023 -0300 [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets that use the AAPCS variant. ARM is the only target that overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way the clash between AAPCS and C++ Modules design should be resolved, but currently it favors AAPCS and thus the test fails, so skip it on arm_eabi. for gcc/testsuite/ChangeLog PR c++/105224 * g++.dg/modules/virt-2_a.C: Skip on arm_eabi. Diff: --- gcc/testsuite/g++.dg/modules/virt-2_a.C | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C b/gcc/testsuite/g++.dg/modules/virt-2_a.C index 580552be5a0..b5050445c3f 100644 --- a/gcc/testsuite/g++.dg/modules/virt-2_a.C +++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C @@ -1,3 +1,6 @@ +// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE, +// in a way that invalidates this test. +// { dg-skip-if "!TARGET_CXX_KEY_METHOD_MAY_BE_INLINE" { arm_eabi } } // { dg-module-do run } // { dg-additional-options -fmodules-ts } export module foo;