From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1647) id B635E385841A; Sat, 25 Feb 2023 20:38:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B635E385841A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677357486; bh=H5KIQ6AwsKE7PiQOvSLc0s0hmiV2MOvjEqj6dyeN6ls=; h=From:To:Subject:Date:From; b=DrHJEvlw+doZ9buyUHcYUF+hTYOK+dmmICJxC6iYjGuptIXnJ5QcfYuTJ5vj3AFA+ heVKU0aVsv45x6+/GkRzXi3U3M1B/75zgEUBxgTaoA7+4RfNc4oWrrOvgdA6t7xao9 HA1bUcqIz3N6vLUMPwYlJvr4jWmDslID8qahN1Wg= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Mikael Morin To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6346] fortran: Reuse associated_dummy memory if previously allocated [PR108923] X-Act-Checkin: gcc X-Git-Author: Mikael Morin X-Git-Refname: refs/heads/master X-Git-Oldrev: a24b2720de5d888a936c350378ae864b81f1a022 X-Git-Newrev: 5c638095e7e0fa4de4e4f7326384a86830b25732 Message-Id: <20230225203806.B635E385841A@sourceware.org> Date: Sat, 25 Feb 2023 20:38:06 +0000 (GMT) List-Id: https://gcc.gnu.org/g:5c638095e7e0fa4de4e4f7326384a86830b25732 commit r13-6346-g5c638095e7e0fa4de4e4f7326384a86830b25732 Author: Mikael Morin Date: Sat Feb 25 21:37:46 2023 +0100 fortran: Reuse associated_dummy memory if previously allocated [PR108923] This avoids making the associted_dummy field point to a new memory chunk if it's already pointing somewhere, in which case doing so would leak the previously allocated chunk. PR fortran/108923 gcc/fortran/ChangeLog: * intrinsic.cc (get_intrinsic_dummy_arg, set_intrinsic_dummy_arg): Rename the former to the latter. Remove the return value, add a reference to the lhs as argument, and do the pointer assignment inside the function. Don't do it if the pointer is already non-NULL. (sort_actual): Update caller. Diff: --- gcc/fortran/intrinsic.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/fortran/intrinsic.cc b/gcc/fortran/intrinsic.cc index 17ee999c3b9..64821c84543 100644 --- a/gcc/fortran/intrinsic.cc +++ b/gcc/fortran/intrinsic.cc @@ -4259,15 +4259,15 @@ remove_nullargs (gfc_actual_arglist **ap) } -static gfc_dummy_arg * -get_intrinsic_dummy_arg (gfc_intrinsic_arg *intrinsic) +static void +set_intrinsic_dummy_arg (gfc_dummy_arg *&dummy_arg, + gfc_intrinsic_arg *intrinsic) { - gfc_dummy_arg * const dummy_arg = gfc_get_dummy_arg (); + if (dummy_arg == NULL) + dummy_arg = gfc_get_dummy_arg (); dummy_arg->intrinsicness = GFC_INTRINSIC_DUMMY_ARG; dummy_arg->u.intrinsic = intrinsic; - - return dummy_arg; } @@ -4430,7 +4430,7 @@ do_sort: if (a == NULL) a = gfc_get_actual_arglist (); - a->associated_dummy = get_intrinsic_dummy_arg (f); + set_intrinsic_dummy_arg (a->associated_dummy, f); if (actual == NULL) *ap = a;