From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2152) id 009C23858D32; Tue, 28 Feb 2023 01:05:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 009C23858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677546303; bh=QZ7/Bu/EISCTCDMmXbuBZe3ccZE2GeuROSLU+zVrElc=; h=From:To:Subject:Date:From; b=X8sbBFLnLEQe/BPxFYNxCkDOcRcfKaUXkOHajr6n/T0hWxHK4aAg3KS6ekG76Bg0V CYnujy4kxN+QkZcYZa6aLhK3QhQLj5w/Ez0Bbpk+Ag+aW1O7/s2x3w22SCU9OwWcrz GnG7QbIp8qlNd/IDvgwr9uHZ3MFZdqPXU7TF0sQg= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Hans-Peter Nilsson To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6364] testsuite: Add -fno-ivopts to gcc.dg/Wuse-after-free-2.c, PR108828 X-Act-Checkin: gcc X-Git-Author: Hans-Peter Nilsson X-Git-Refname: refs/heads/master X-Git-Oldrev: bf0e0fc0ea47698c81ddb0eb00a71f9ad251c4a1 X-Git-Newrev: 8c58f4b798177d419c5af37b7e23c490849f2d45 Message-Id: <20230228010503.009C23858D32@sourceware.org> Date: Tue, 28 Feb 2023 01:05:02 +0000 (GMT) List-Id: https://gcc.gnu.org/g:8c58f4b798177d419c5af37b7e23c490849f2d45 commit r13-6364-g8c58f4b798177d419c5af37b7e23c490849f2d45 Author: Hans-Peter Nilsson Date: Fri Feb 24 17:22:02 2023 +0100 testsuite: Add -fno-ivopts to gcc.dg/Wuse-after-free-2.c, PR108828 For cris-elf before this patch, ever since it was added, this test gets: Running /x/gcc/testsuite/gcc.dg/dg.exp ... FAIL: gcc.dg/Wuse-after-free-2.c (test for warnings, line 115) FAIL: gcc.dg/Wuse-after-free-2.c (test for warnings, line 116) and comparing tree dumps with a native x86_64-pc-linux-gnu run shows a suspicious difference in the "180t.ivopts" dump. Indeed -fno-ivopts makes the warning appear for cris-elf too. It was suggested to simply add -fno-ivopts to the test-flags, like before -fno-tree-loop-distribute-patterns was added; thus. PR tree-optimization/108828 * gcc.dg/Wuse-after-free-2.c: Add -fno-ivopts. Diff: --- gcc/testsuite/gcc.dg/Wuse-after-free-2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/Wuse-after-free-2.c b/gcc/testsuite/gcc.dg/Wuse-after-free-2.c index 68ec75845ce..ebc051690db 100644 --- a/gcc/testsuite/gcc.dg/Wuse-after-free-2.c +++ b/gcc/testsuite/gcc.dg/Wuse-after-free-2.c @@ -1,6 +1,6 @@ /* PR middle-end/104232 - spurious -Wuse-after-free after conditional free { dg-do compile } - { dg-options "-O2 -Wall -fno-tree-loop-distribute-patterns" } */ + { dg-options "-O2 -Wall -fno-tree-loop-distribute-patterns -fno-ivopts" } */ void free (void*); @@ -108,7 +108,8 @@ int warn_cond_loop (char *p) char *q = p; /* -fno-tree-loop-distribute-patterns ensures this does not get converted - into rawmemchr (making q and p unrelated). */ + into rawmemchr (making q and p unrelated). Also, -fno-ivopts is required + for some targets, to not lose track of the pointer. */ while (*q) ++q;