public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-6369] testsuite: No xfail infoleak-vfio_iommu_type1.c bogus for default_packed
Date: Tue, 28 Feb 2023 01:31:08 +0000 (GMT)	[thread overview]
Message-ID: <20230228013108.EE09D3858D32@sourceware.org> (raw)

https://gcc.gnu.org/g:cf2ba92481d56ab923ccae96f29764e871979451

commit r13-6369-gcf2ba92481d56ab923ccae96f29764e871979451
Author: Hans-Peter Nilsson <hp@axis.com>
Date:   Mon Feb 27 20:44:46 2023 +0100

    testsuite: No xfail infoleak-vfio_iommu_type1.c bogus for default_packed
    
    There are no messages about padding for targets that don't
    pad, i.e. default_packed.  Noticed for cris-elf, verified
    for pru-elf at gcc-testresults@.
    
    testsuite:
            * gcc.dg/plugin/infoleak-vfio_iommu_type1.c: Don't xfail bogus
            message for "default_packed" targets.

Diff:
---
 gcc/testsuite/gcc.dg/plugin/infoleak-vfio_iommu_type1.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/plugin/infoleak-vfio_iommu_type1.c b/gcc/testsuite/gcc.dg/plugin/infoleak-vfio_iommu_type1.c
index 51ad5db2bab..af320b6b17e 100644
--- a/gcc/testsuite/gcc.dg/plugin/infoleak-vfio_iommu_type1.c
+++ b/gcc/testsuite/gcc.dg/plugin/infoleak-vfio_iommu_type1.c
@@ -37,8 +37,8 @@ int vfio_iommu_type1_get_info(unsigned long arg)
     info.cap_offset = 0;
   }
 
-  /* The padding bytes (20-23) are uninitialized, but can't be written
-     back, since minsz is either 16 or 20.  */
-  return copy_to_user((void *)arg, &info, minsz) ? -14 : 0; /* { dg-bogus "exposure" "" { xfail *-*-* } } */
+  /* The padding bytes (20-23, but applicable just for targets with padding) are
+     uninitialized, but can't be written back, since minsz is either 16 or 20.  */
+  return copy_to_user((void *)arg, &info, minsz) ? -14 : 0; /* { dg-bogus "exposure" "" { xfail { ! default_packed } } } */
   // TODO: false +ve due to not handling minsz being either 16 or 20
 }

                 reply	other threads:[~2023-02-28  1:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230228013108.EE09D3858D32@sourceware.org \
    --to=hp@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).