From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2209) id 1242F3858D33; Thu, 2 Mar 2023 19:02:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1242F3858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677783750; bh=4ABt4GhIsz9JZmbrW0HazXakJJgHJv57owjKJjePOsI=; h=From:To:Subject:Date:From; b=hdbb74rMl+BGHdT7KQMoqCkBf4lMKhHlu3rTrMExKoS+amZh++/3N63wt9Evv8hOZ Tf2X0uin4GE9Uhl8NDnh1BWZ7uCakg+34CddYAmJsgjLgjoay+7SddoM8uwns+rqYX mC7DdZt5wMQJ1qzn5rMmjz1jBa3zbY73zXCgagbE= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: David Malcolm To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6420] analyzer: fix uninit false +ves reading from DECL_HARD_REGISTER [PR108968] X-Act-Checkin: gcc X-Git-Author: David Malcolm X-Git-Refname: refs/heads/master X-Git-Oldrev: 4d82022bfd15d36717bf60a11e75e9ea02204269 X-Git-Newrev: 20bd258d0fa09837b3a93478ef92d8789cbcd442 Message-Id: <20230302190230.1242F3858D33@sourceware.org> Date: Thu, 2 Mar 2023 19:02:30 +0000 (GMT) List-Id: https://gcc.gnu.org/g:20bd258d0fa09837b3a93478ef92d8789cbcd442 commit r13-6420-g20bd258d0fa09837b3a93478ef92d8789cbcd442 Author: David Malcolm Date: Thu Mar 2 14:01:19 2023 -0500 analyzer: fix uninit false +ves reading from DECL_HARD_REGISTER [PR108968] gcc/analyzer/ChangeLog: PR analyzer/108968 * region-model.cc (region_model::get_rvalue_1): Handle VAR_DECLs with a DECL_HARD_REGISTER by returning UNKNOWN. gcc/testsuite/ChangeLog: PR analyzer/108968 * gcc.dg/analyzer/uninit-pr108968-register.c: New test. Signed-off-by: David Malcolm Diff: --- gcc/analyzer/region-model.cc | 9 ++++++++- gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c | 9 +++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/gcc/analyzer/region-model.cc b/gcc/analyzer/region-model.cc index 2187aecbe91..bf07cec2884 100644 --- a/gcc/analyzer/region-model.cc +++ b/gcc/analyzer/region-model.cc @@ -2203,9 +2203,16 @@ region_model::get_rvalue_1 (path_var pv, region_model_context *ctxt) const return get_rvalue_for_bits (TREE_TYPE (expr), reg, bits, ctxt); } - case SSA_NAME: case VAR_DECL: + if (DECL_HARD_REGISTER (pv.m_tree)) + { + /* If it has a hard register, it doesn't have a memory region + and can't be referred to as an lvalue. */ + return m_mgr->get_or_create_unknown_svalue (TREE_TYPE (pv.m_tree)); + } + /* Fall through. */ case PARM_DECL: + case SSA_NAME: case RESULT_DECL: case ARRAY_REF: { diff --git a/gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c b/gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c new file mode 100644 index 00000000000..a76c09e7b14 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c @@ -0,0 +1,9 @@ +/* { dg-do compile { target x86_64-*-* } } */ + +#define STACK_SIZE 4096 +struct cpu_info {}; +struct cpu_info *get_cpu_info(void) +{ + register unsigned long sp asm("rsp"); + return (struct cpu_info *)((sp | (STACK_SIZE - 1)) + 1) - 1; /* { dg-bogus "use of uninitialized value 'sp'" } */ +}