public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6478] Remove remaining traces of m_vecdata from comments [PR109006] Date: Sat, 4 Mar 2023 10:24:39 +0000 (GMT) [thread overview] Message-ID: <20230304102439.9F9573858D1E@sourceware.org> (raw) https://gcc.gnu.org/g:4ee2f419fe42222dbb21dfb0622cc7c0e46a2261 commit r13-6478-g4ee2f419fe42222dbb21dfb0622cc7c0e46a2261 Author: Jakub Jelinek <jakub@redhat.com> Date: Sat Mar 4 11:24:04 2023 +0100 Remove remaining traces of m_vecdata from comments [PR109006] The following patch adjusts remaining references to the removed m_vecdata array from vec.h in various comments. 2023-03-04 Jakub Jelinek <jakub@redhat.com> PR middle-end/109006 * vec.cc (test_auto_alias): Adjust comment for removal of m_vecdata. * read-rtl-function.cc (function_reader::parse_block): Likewise. * gdbhooks.py: Likewise. Diff: --- gcc/gdbhooks.py | 6 +++--- gcc/read-rtl-function.cc | 9 +++++---- gcc/vec.cc | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/gcc/gdbhooks.py b/gcc/gdbhooks.py index e29bd458909..32ddaf625e6 100644 --- a/gcc/gdbhooks.py +++ b/gcc/gdbhooks.py @@ -133,10 +133,10 @@ vector: attempting to do so instead gives you the vec itself (for vec[0]), or a (probably) invalid cast to vec<> for the memory after the vec (for vec[1] onwards). -Instead (for now) you must access m_vecdata: - (gdb) p bb->preds->m_vecdata[0] +Instead (for now) you must access the payload directly: + (gdb) p ((edge_def**)(bb->preds+1))[0] $20 = <edge 0x7ffff044d380 (3 -> 5)> - (gdb) p bb->preds->m_vecdata[1] + (gdb) p ((edge_def**)(bb->preds+1))[1] $21 = <edge 0x7ffff044d3b8 (4 -> 5)> """ import os.path diff --git a/gcc/read-rtl-function.cc b/gcc/read-rtl-function.cc index 74bd4ddb336..b89a811e037 100644 --- a/gcc/read-rtl-function.cc +++ b/gcc/read-rtl-function.cc @@ -622,10 +622,11 @@ function_reader::parse_block () These can get out-of-sync when basic blocks are optimized away. They get back in sync by "compact_blocks". - We reconstruct cfun->cfg->x_basic_block_info->m_vecdata with NULL - values in it for any missing basic blocks, so that (a) == (b) for - all of the blocks we create. The doubly-linked list of basic - blocks (next_bb/prev_bb) skips over these "holes". */ + We reconstruct cfun->cfg->x_basic_block_info->address () pointed + vector elements with NULL values in it for any missing basic blocks, + so that (a) == (b) for all of the blocks we create. The + doubly-linked list of basic blocks (next_bb/prev_bb) skips over + these "holes". */ if (m_highest_bb_idx < bb_idx) m_highest_bb_idx = bb_idx; diff --git a/gcc/vec.cc b/gcc/vec.cc index 2128f6666b1..69c86f63ee8 100644 --- a/gcc/vec.cc +++ b/gcc/vec.cc @@ -568,7 +568,7 @@ test_auto_delete_vec () ASSERT_EQ (dtor_count, 2); } -/* Verify accesses to m_vecdata are done indirectly. */ +/* Verify accesses to vector elements are done indirectly. */ static void test_auto_alias ()
reply other threads:[~2023-03-04 10:24 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230304102439.9F9573858D1E@sourceware.org \ --to=jakub@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).