public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Kito Cheng <kito@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-6482] RISC-V: Fix wrong partial subreg check for bsetidisi
Date: Sun,  5 Mar 2023 09:17:03 +0000 (GMT)	[thread overview]
Message-ID: <20230305091703.5EC0E3858D1E@sourceware.org> (raw)

https://gcc.gnu.org/g:9debb240a4b1a711c0648fd9e4385dbde5ad45fd

commit r13-6482-g9debb240a4b1a711c0648fd9e4385dbde5ad45fd
Author: Lin Sinan <sinan.lin@linux.alibaba.com>
Date:   Tue Feb 28 13:00:36 2023 +0800

    RISC-V: Fix wrong partial subreg check for bsetidisi
    
    The partial subreg check should be for subreg operand(operand 1) instead of
    the immediate operand(operand 2). This change also fix pr68648.c in zbs.
    
    gcc/ChangeLog:
    
            * config/riscv/bitmanip.md: Fix wrong index in the check.
    Reviewed-by: <philipp.tomsich@vrull.eu>

Diff:
---
 gcc/config/riscv/bitmanip.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/riscv/bitmanip.md b/gcc/config/riscv/bitmanip.md
index 14d18edbe62..58a86bd929f 100644
--- a/gcc/config/riscv/bitmanip.md
+++ b/gcc/config/riscv/bitmanip.md
@@ -442,7 +442,7 @@
 	(ior:DI (sign_extend:DI (match_operand:SI 1 "register_operand" "r"))
 		(match_operand 2 "single_bit_mask_operand" "i")))]
   "TARGET_ZBS && TARGET_64BIT
-   && !partial_subreg_p (operands[2])"
+   && !partial_subreg_p (operands[1])"
   "bseti\t%0,%1,%S2"
   [(set_attr "type" "bitmanip")])

                 reply	other threads:[~2023-03-05  9:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230305091703.5EC0E3858D1E@sourceware.org \
    --to=kito@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).