public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/rust/master] gccrs: make predicate bounds overwrite-able Date: Sun, 5 Mar 2023 11:42:55 +0000 (GMT) [thread overview] Message-ID: <20230305114255.B76D83858414@sourceware.org> (raw) https://gcc.gnu.org/g:a4aeea9a90b3ed23e154d325b0224d788a89f609 commit a4aeea9a90b3ed23e154d325b0224d788a89f609 Author: Philip Herron <herron.philip@googlemail.com> Date: Fri Mar 3 18:17:50 2023 +0000 gccrs: make predicate bounds overwrite-able When compiling types especially when using queries it needs to be permissive and allow them to be overwritten and a predicate might have one set of details in one senario and a new one with the same id later on but with different types. Fixes #1524 Signed-off-by: Philip Herron <herron.philip@googlemail.com> gcc/rust/ChangeLog: * typecheck/rust-typecheck-context.cc (TypeCheckContext::insert_resolved_predicate): remove gcc/testsuite/ChangeLog: * rust/compile/issue-1524.rs: New test. Diff: --- gcc/rust/typecheck/rust-typecheck-context.cc | 4 +-- gcc/testsuite/rust/compile/issue-1524.rs | 49 ++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 2 deletions(-) diff --git a/gcc/rust/typecheck/rust-typecheck-context.cc b/gcc/rust/typecheck/rust-typecheck-context.cc index 096ce26f1fa..6bc4160e76e 100644 --- a/gcc/rust/typecheck/rust-typecheck-context.cc +++ b/gcc/rust/typecheck/rust-typecheck-context.cc @@ -437,8 +437,8 @@ void TypeCheckContext::insert_resolved_predicate (HirId id, TyTy::TypeBoundPredicate predicate) { - auto it = predicates.find (id); - rust_assert (it == predicates.end ()); + // auto it = predicates.find (id); + // rust_assert (it == predicates.end ()); predicates.insert ({id, predicate}); } diff --git a/gcc/testsuite/rust/compile/issue-1524.rs b/gcc/testsuite/rust/compile/issue-1524.rs new file mode 100644 index 00000000000..e46efe4595f --- /dev/null +++ b/gcc/testsuite/rust/compile/issue-1524.rs @@ -0,0 +1,49 @@ +// { dg-additional-options "-w" } +// https://github.com/Rust-GCC/gccrs/issues/1524 +// https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/src/test/ui/methods/method-normalize-bounds-issue-20604.rs +trait Hasher { + type Output; + fn finish(&self) -> Self::Output; +} + +trait Hash<H: Hasher> { + fn hash(&self, h: &mut H); +} + +trait HashState { + type Wut: Hasher; + fn hasher(&self) -> Self::Wut; +} + +struct SipHasher; +impl Hasher for SipHasher { + type Output = u64; + fn finish(&self) -> u64 { 4 } +} + +impl Hash<SipHasher> for isize { + fn hash(&self, h: &mut SipHasher) {} +} + +struct SipState; +impl HashState for SipState { + type Wut = SipHasher; + fn hasher(&self) -> SipHasher { SipHasher } +} + +struct Map<S> { + s: S, +} + +impl<S> Map<S> + where S: HashState, + <S as HashState>::Wut: Hasher<Output=u64>, +{ + fn foo<K>(&self, k: K) where K: Hash< <S as HashState>::Wut> {} +} + +fn foo<K: Hash<SipHasher>>(map: &Map<SipState>) { + map.foo(22); +} + +fn main() {}
reply other threads:[~2023-03-05 11:42 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230305114255.B76D83858414@sourceware.org \ --to=tschwinge@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).