From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1643) id C8818385840A; Sun, 5 Mar 2023 11:43:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C8818385840A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678016580; bh=db4CcxXD0AYWBjRHJ6J3Ff99wGfGuT4sv4OULSq+Y1I=; h=From:To:Subject:Date:From; b=Qfw4YDQ6u3ehqTalOMy8fVbmbz19JXC2zPt5CDFPC+yu9a3xhYPOjsM+1Ovp8I6Na 29WAnD48niJ+RCNqN+qTayHWlN689FLdAd7Bw4dBbbTGeeVSkUwOey+nGRfo5H7Q5B atRjyJyktESke6aM2Xtm16GZz1sNOfmzBzur/KHY= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Thomas Schwinge To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/rust/master] Resolve closure parameters without given type X-Act-Checkin: gcc X-Git-Author: Owen Avery X-Git-Refname: refs/heads/devel/rust/master X-Git-Oldrev: a4aeea9a90b3ed23e154d325b0224d788a89f609 X-Git-Newrev: ae91a0a3f2b44e5b011d3742a71c3c5030558bc8 Message-Id: <20230305114300.C8818385840A@sourceware.org> Date: Sun, 5 Mar 2023 11:43:00 +0000 (GMT) List-Id: https://gcc.gnu.org/g:ae91a0a3f2b44e5b011d3742a71c3c5030558bc8 commit ae91a0a3f2b44e5b011d3742a71c3c5030558bc8 Author: Owen Avery Date: Fri Mar 3 20:05:59 2023 -0500 Resolve closure parameters without given type gcc/rust/ChangeLog: * resolve/rust-early-name-resolver.cc (EarlyNameResolver::visit): Check for closure parameter without given type. gcc/testsuite/ChangeLog: * rust/compile/closure_no_type_anno.rs: Extend test. Signed-off-by: Owen Avery Diff: --- gcc/rust/resolve/rust-early-name-resolver.cc | 3 ++- gcc/testsuite/rust/compile/closure_no_type_anno.rs | 9 +++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gcc/rust/resolve/rust-early-name-resolver.cc b/gcc/rust/resolve/rust-early-name-resolver.cc index 10f7626dc7f..69852280630 100644 --- a/gcc/rust/resolve/rust-early-name-resolver.cc +++ b/gcc/rust/resolve/rust-early-name-resolver.cc @@ -326,7 +326,8 @@ EarlyNameResolver::visit (AST::ClosureExprInner &expr) expr.get_definition_expr ()->accept_vis (*this); for (auto ¶m : expr.get_params ()) - param.get_type ()->accept_vis (*this); + if (param.has_type_given ()) + param.get_type ()->accept_vis (*this); } void diff --git a/gcc/testsuite/rust/compile/closure_no_type_anno.rs b/gcc/testsuite/rust/compile/closure_no_type_anno.rs index beade7607f0..ff2c8b88a8a 100644 --- a/gcc/testsuite/rust/compile/closure_no_type_anno.rs +++ b/gcc/testsuite/rust/compile/closure_no_type_anno.rs @@ -1,5 +1,10 @@ -// { dg-additional-options "-fsyntax-only" } +#[lang = "fn_once"] +trait FnOnce { + type Output; + + fn call_once(self, args: Args) -> Self::Output; +} pub fn foo() { - let a = |_| 15; + let a = |_| 15; // { dg-error "type annotations needed" } }