public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Kito Cheng <kito@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6495] RISC-V: Fix ICE for avl_single-86/avl_single-88/avl_single-90 Date: Sun, 5 Mar 2023 17:23:58 +0000 (GMT) [thread overview] Message-ID: <20230305172358.E3FA53858D28@sourceware.org> (raw) https://gcc.gnu.org/g:44c918b50af64d1c0f27067b2671e1a4f744841b commit r13-6495-g44c918b50af64d1c0f27067b2671e1a4f744841b Author: Ju-Zhe Zhong <juzhe.zhong@rivai.ai> Date: Sun Mar 5 18:24:30 2023 +0800 RISC-V: Fix ICE for avl_single-86/avl_single-88/avl_single-90 If prop is demand of vsetvl instruction and reaching doesn't demand AVL. We don't backward propagate since vsetvl instruction has no side effects. FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-86.c -Og -g (internal compiler error: Segmentation fault) FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-86.c -Og -g (test for excess errors) FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-88.c -Og -g (internal compiler error: Segmentation fault) FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-88.c -Og -g (test for excess errors) FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-90.c -Og -g (internal compiler error: Segmentation fault) FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-90.c -Og -g (test for excess errors) gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (reg_available_p): Fix bug. (pass_vsetvl::backward_demand_fusion): Ditto. Diff: --- gcc/config/riscv/riscv-vsetvl.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc index 9e25102a4f2..73f36a70331 100644 --- a/gcc/config/riscv/riscv-vsetvl.cc +++ b/gcc/config/riscv/riscv-vsetvl.cc @@ -1528,7 +1528,7 @@ static bool reg_available_p (const bb_info *bb, const vector_insn_info &info) { if (!info.get_avl_source ()) - return true; + return false; insn_info *insn = info.get_avl_source ()->insn (); if (insn->bb () == bb) return before_p (insn, info.get_insn ()); @@ -3040,6 +3040,12 @@ pass_vsetvl::backward_demand_fusion (void) continue; if (e->src->index == ENTRY_BLOCK_PTR_FOR_FN (cfun)->index) continue; + /* If prop is demand of vsetvl instruction and reaching doesn't demand + AVL. We don't backward propagate since vsetvl instruction has no + side effects. */ + if (vsetvl_insn_p (prop.get_insn ()->rtl ()) + && propagate_avl_across_demands_p (prop, block_info.reaching_out)) + continue; if (block_info.reaching_out.unknown_p ()) continue;
reply other threads:[~2023-03-05 17:23 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230305172358.E3FA53858D28@sourceware.org \ --to=kito@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).