public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Tamar Christina <tnfchris@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6564] middle-end: On emergency dumps finish the graph generation. Date: Thu, 9 Mar 2023 19:44:26 +0000 (GMT) [thread overview] Message-ID: <20230309194426.067C0385842B@sourceware.org> (raw) https://gcc.gnu.org/g:ec4bc86b4399e50a0c848472126dad776772ee1c commit r13-6564-gec4bc86b4399e50a0c848472126dad776772ee1c Author: Tamar Christina <tamar.christina@arm.com> Date: Thu Mar 9 19:43:08 2023 +0000 middle-end: On emergency dumps finish the graph generation. When doing an emergency dump the cfg output dumps are corrupted because the ending "}" is missing. Normally when the pass manager finishes it would call finish_graph_dump_file to produce this. This is called here because each pass can dump multiple digraphs. However during an emergency dump we only dump the current function and so after that is done we never go back to the pass manager. As such, we need to manually call finish_graph_dump_file in order to properly finish off graph generation. With this -ftree-dump-*-graph works properly during a crash dump. gcc/ChangeLog: * passes.cc (emergency_dump_function): Finish graph generation. Diff: --- gcc/passes.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gcc/passes.cc b/gcc/passes.cc index 91d560720c3..2f0e378b8b2 100644 --- a/gcc/passes.cc +++ b/gcc/passes.cc @@ -1845,6 +1845,13 @@ emergency_dump_function () fprintf (dump_file, "\n\n\nEMERGENCY DUMP:\n\n"); execute_function_dump (cfun, current_pass); + /* Normally the passmanager will close the graphs as a pass could be wanting + to print multiple digraphs. But during an emergency dump there can only be + one and we must finish the graph manually. */ + if ((cfun->curr_properties & PROP_cfg) + && (dump_flags & TDF_GRAPH)) + finish_graph_dump_file (dump_file_name); + if (symtab && current_pass->type == IPA_PASS) symtab->dump (dump_file); }
reply other threads:[~2023-03-09 19:44 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230309194426.067C0385842B@sourceware.org \ --to=tnfchris@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).