From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id A0A8A3858033; Fri, 10 Mar 2023 14:08:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0A8A3858033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678457309; bh=fqv//c7e1TuM3MlAQdduZfDxs0ogJNdv/KDnxSh7B+w=; h=From:To:Subject:Date:From; b=xdUnsuJDiK0Q1PHvldNztcMgQhHIFOxz425Fer9TPmmZkOPbUESoDYHIxpAQlwmNw qV6xN6ED7mLUvEy0S8JBbIYIrFQHTkIE5b6fcYFbNPEPrBMoHnftZ3uXOOA7q4Xn/C i+vsiLA0GSI1MWiC1BWFaTNdvTEGn3hfH+4vUgtw= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6584] Speedup PTA solving for call constraint sets X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 649f1939baf11f45fd3579b8b9601c7840a097b3 X-Git-Newrev: 413ec1d12c50f8e2e6adb4de30482780bdfdeeb4 Message-Id: <20230310140829.A0A8A3858033@sourceware.org> Date: Fri, 10 Mar 2023 14:08:29 +0000 (GMT) List-Id: https://gcc.gnu.org/g:413ec1d12c50f8e2e6adb4de30482780bdfdeeb4 commit r13-6584-g413ec1d12c50f8e2e6adb4de30482780bdfdeeb4 Author: Richard Biener Date: Fri Mar 10 14:15:14 2023 +0100 Speedup PTA solving for call constraint sets With calls we now often get contraints like callarg = *callarg + UNKNOWN or similar cases. The important thing to note is that this complex constraint changes the node solution itself, so when solving the node is marked as changed immediately again. When that happens it's profitable to iterate that self-cycle immediately so we maximize cache reuse and build up the successor graph quickly to get better topological ordering and reduce the number of iterations of the solving. For a testcase derived from ceph this reduces the time spent in PTA solving from 453s to 92s which is quite significant. * tree-ssa-structalias.cc (solve_graph): Immediately iterate self-cycles. Diff: --- gcc/tree-ssa-structalias.cc | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/gcc/tree-ssa-structalias.cc b/gcc/tree-ssa-structalias.cc index 07e0fd6827a..c3c5bce42df 100644 --- a/gcc/tree-ssa-structalias.cc +++ b/gcc/tree-ssa-structalias.cc @@ -2775,8 +2775,15 @@ solve_graph (constraint_graph_t graph) continue; /* If the node has changed, we need to process the - complex constraints and outgoing edges again. */ - if (bitmap_clear_bit (changed, i)) + complex constraints and outgoing edges again. For complex + constraints that modify i itself, like the common group of + callarg = callarg + UNKNOWN; + callarg = *callarg + UNKNOWN; + *callarg = callescape; + make sure to iterate immediately because that maximizes + cache reuse and expands the graph quickest, leading to + better visitation order in the next iteration. */ + while (bitmap_clear_bit (changed, i)) { unsigned int j; constraint_t c; @@ -2794,7 +2801,7 @@ solve_graph (constraint_graph_t graph) ??? But we shouldn't ended up with "changed" set ... */ if (vi->oldsolution && bitmap_bit_p (vi->oldsolution, anything_id)) - continue; + break; bitmap_copy (pts, get_varinfo (find (anything_id))->solution); } else if (vi->oldsolution) @@ -2803,7 +2810,7 @@ solve_graph (constraint_graph_t graph) bitmap_copy (pts, vi->solution); if (bitmap_empty_p (pts)) - continue; + break; if (vi->oldsolution) bitmap_ior_into (vi->oldsolution, pts);