From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1643) id DDFAA3858D38; Fri, 10 Mar 2023 14:39:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDFAA3858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678459186; bh=JlDkA9varU6XEbaxmH7yMsTIeBPaGf72PzgCONbCuXQ=; h=From:To:Subject:Date:From; b=QF66h7yym3GdwLDg5GUmnfJuoCYOjQKfGZncXhZIjK+Pke/SETzn8Dm2T+EKD/Co6 4jvmheV6wJkQtjAw9IHS94v9U1T7MsgK/zgecUttLpWCivW9wFZCuvRfanlSbWHkzN CDAudQpnuxRF/A+7t45nWIt2DaTYoiRSDotHlKvM= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Thomas Schwinge To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6586] OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait' X-Act-Checkin: gcc X-Git-Author: Thomas Schwinge X-Git-Refname: refs/heads/master X-Git-Oldrev: 442d51a20ef13a8e6c080ca30bc37fc93b6bfac4 X-Git-Newrev: b5037d4a073f2e4625afab5ec1f35624d9f9eba1 Message-Id: <20230310143946.DDFAA3858D38@sourceware.org> Date: Fri, 10 Mar 2023 14:39:46 +0000 (GMT) List-Id: https://gcc.gnu.org/g:b5037d4a073f2e4625afab5ec1f35624d9f9eba1 commit r13-6586-gb5037d4a073f2e4625afab5ec1f35624d9f9eba1 Author: Thomas Schwinge Date: Fri Feb 24 16:17:57 2023 +0100 OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait' We're not taking such a shortcut anywhere else, and (with future changes) it has potential to confuse things if synchronization in a libgomp plugin happens to have side effects even if an async queue currently is empty. libgomp/ * oacc-async.c (goacc_wait): Remove 'acc_async_test' -> skip shortcut. Diff: --- libgomp/oacc-async.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libgomp/oacc-async.c b/libgomp/oacc-async.c index 2562afbd753..82d00b64b50 100644 --- a/libgomp/oacc-async.c +++ b/libgomp/oacc-async.c @@ -410,9 +410,6 @@ goacc_wait (int async, int num_waits, va_list *ap) break; } - if (acc_async_test (qid)) - continue; - if (async == acc_async_sync) acc_wait (qid); else if (qid == async)