From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2119) id 10D843858D1E; Sat, 11 Mar 2023 16:24:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10D843858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678551860; bh=1SvZaO3SgInONqIXkSugttn7kg/AhJ93MZO7cVdsK1U=; h=From:To:Subject:Date:From; b=gytQRBKZ7dwpdO8oACoB+RV1f1uX8619U/p8Nb5x3zuziiH+fZCe6LwJKVpi1cZGS VpsrrKmXta4GsUn/JY+jMsFa6HNi2V+t8+xPwq/+XbkUsCE7Ok9H2dRp5MakqZ4L7v r6HcQjePpuunkoDoJZtremHn8FDRxMu5t5E6DqDY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jeff Law To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6606] Re: [PATCH 2/2] Corrected pr25521.c target matching. X-Act-Checkin: gcc X-Git-Author: Cupertino Miranda X-Git-Refname: refs/heads/master X-Git-Oldrev: 2cf5f485e0351bb1faf46196a99e524688f3966e X-Git-Newrev: 23ff46459a4a3bbb0a2420f2bbb84d0247303e2f Message-Id: <20230311162420.10D843858D1E@sourceware.org> Date: Sat, 11 Mar 2023 16:24:20 +0000 (GMT) List-Id: https://gcc.gnu.org/g:23ff46459a4a3bbb0a2420f2bbb84d0247303e2f commit r13-6606-g23ff46459a4a3bbb0a2420f2bbb84d0247303e2f Author: Cupertino Miranda Date: Sat Mar 11 09:22:36 2023 -0700 Re: [PATCH 2/2] Corrected pr25521.c target matching. gcc/testsuite: * gcc.dg/pr25521.c: Skip for !const_volatile_readonly_section targets. Adjust expected output. * lib/target-supports.exp (check_effective_target_const_volatile_readonly_section): New Diff: --- gcc/testsuite/gcc.dg/pr25521.c | 7 ++++--- gcc/testsuite/lib/target-supports.exp | 10 ++++++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c index 63363a03b9f..82b4cd88ec0 100644 --- a/gcc/testsuite/gcc.dg/pr25521.c +++ b/gcc/testsuite/gcc.dg/pr25521.c @@ -2,9 +2,10 @@ sections. { dg-require-effective-target elf } - { dg-do compile } */ + { dg-do compile } + { dg-skip-if "" { ! const_volatile_readonly_section } } */ const volatile int foo = 30; - -/* { dg-final { scan-assembler "\\.s\?rodata" } } */ +/* { dg-final { scan-assembler {.section C,} { target { rx-*-* } } } } */ +/* { dg-final { scan-assembler-symbol-section {^_?foo$} {^\.(const|s?rodata)} { target { ! "rx-*-*" } } } } */ diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 84ac7371523..5e4a73af0de 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -12320,3 +12320,13 @@ proc check_is_prog_name_available { prog } { return 1 } + +# returns 1 if target does selects a readonly section for const volatile variables. +proc check_effective_target_const_volatile_readonly_section { } { + + if { [istarget powerpc-*-*] + || [check-flags { "" { powerpc64-*-* } { -m32 } }] } { + return 0 + } + return 1 +}