From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id CE5C23858D32; Tue, 14 Mar 2023 08:16:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE5C23858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678781783; bh=zm9jMktjMZhlgXHapUwHjfrvDYmLetPAWspGQ6yMNHo=; h=From:To:Subject:Date:From; b=n930njaTHOV3c3FslEmPL0ZGcErQrPvsM9RmNKpRiuC3vEMQ8/dkvwZ7kdiK7J+dj 2uAWNXEMux1y5JlmVaSDk+X5i/7vdyk349qYKaKNxmZtrXkcUkME7kAQhI8VGd66gN leqinye/aiGBXGez6qK8AOhzUB4BwZqt5uVnSE4M= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6653] tree-vect-patterns: Fix up ICE in upper_bound [PR109115] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: 5159a1f1e91e03d4b82808a0062697318232543f X-Git-Newrev: 72b52751c60abb327c73716259485d04b8eabe4f Message-Id: <20230314081623.CE5C23858D32@sourceware.org> Date: Tue, 14 Mar 2023 08:16:23 +0000 (GMT) List-Id: https://gcc.gnu.org/g:72b52751c60abb327c73716259485d04b8eabe4f commit r13-6653-g72b52751c60abb327c73716259485d04b8eabe4f Author: Jakub Jelinek Date: Tue Mar 14 09:15:38 2023 +0100 tree-vect-patterns: Fix up ICE in upper_bound [PR109115] As mentioned in the PR, range_of_expr returns false if the type of the expression isn't suitable for corresponding range type, but doesn't if the range is undefined for other reasons. Still, lower/upper_bound is defined only for ranges which actually have at least one pair of subranges, VR_UNDEFINED range doesn't have it. 2023-03-14 Jakub Jelinek PR tree-optimization/109115 * tree-vect-patterns.cc (vect_recog_divmod_pattern): Don't use r.upper_bound () on r.undefined_p () range. * gcc.dg/pr109115.c: New test. Diff: --- gcc/testsuite/gcc.dg/pr109115.c | 20 ++++++++++++++++++++ gcc/tree-vect-patterns.cc | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/pr109115.c b/gcc/testsuite/gcc.dg/pr109115.c new file mode 100644 index 00000000000..780477105ed --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr109115.c @@ -0,0 +1,20 @@ +/* PR tree-optimization/109115 */ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +int a, b; + +int +main () +{ + unsigned short c = a, e = -1; + if (b) + { + unsigned d = (a ^ 1U) / a & c; + int f = (~d >> ~a) / e; + if (a) + f = a; + a = f; + } + return 0; +} diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc index 887f02bf336..8802141cd6e 100644 --- a/gcc/tree-vect-patterns.cc +++ b/gcc/tree-vect-patterns.cc @@ -3973,7 +3973,7 @@ vect_recog_divmod_pattern (vec_info *vinfo, /* Check that no overflow will occur. If we don't have range information we can't perform the optimization. */ - if (ranger.range_of_expr (r, oprnd0, stmt)) + if (ranger.range_of_expr (r, oprnd0, stmt) && !r.undefined_p ()) { wide_int max = r.upper_bound (); wide_int one = wi::shwi (1, prec);