public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Uros Bizjak <uros@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-6665] i386: Use movss to implement V2SImode VEC_PERM.
Date: Tue, 14 Mar 2023 17:41:47 +0000 (GMT) [thread overview]
Message-ID: <20230314174147.94D6F3858D33@sourceware.org> (raw)
https://gcc.gnu.org/g:4bcc3b5cc87505d13cda82846db2e223a9b41f79
commit r13-6665-g4bcc3b5cc87505d13cda82846db2e223a9b41f79
Author: Uros Bizjak <ubizjak@gmail.com>
Date: Tue Mar 14 18:41:06 2023 +0100
i386: Use movss to implement V2SImode VEC_PERM.
Perform V2SI vector permutation in the same way as existing V2SF for
TARGET_MMX_WITH_SSE targets. The testcase:
typedef unsigned int v2si __attribute__((vector_size(8)));
v2si foo(v2si x, v2si y) { return (v2si){y[0], x[1]}; }
is currently compiled to (-O2):
foo:
movdqa %xmm0, %xmm2
movdqa %xmm1, %xmm0
pshufd $0xe5, %xmm2, %xmm2
punpckldq %xmm2, %xmm0
ret
and with the patched compiler:
foo:
movss %xmm1, %xmm0
ret
The functionality is already tested in gcc.target/i386/vperm-v2si.c
gcc/ChangeLog:
* config/i386/i386-expand.cc (expand_vec_perm_movs):
Handle V2SImode for TARGET_MMX_WITH_SSE.
* config/i386/mmx.md (*mmx_movss_<mode>): Rename from *mmx_movss
using V2FI mode iterator to handle both V2SI and V2SF modes.
Diff:
---
gcc/config/i386/i386-expand.cc | 8 +++-----
gcc/config/i386/mmx.md | 10 +++++-----
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc
index 1094ece8b6d..6cc8bd5c80c 100644
--- a/gcc/config/i386/i386-expand.cc
+++ b/gcc/config/i386/i386-expand.cc
@@ -18949,11 +18949,9 @@ expand_vec_perm_movs (struct expand_vec_perm_d *d)
if (d->one_operand_p)
return false;
- if (!(TARGET_SSE && vmode == V4SFmode)
- && !(TARGET_SSE && vmode == V4SImode)
- && !(TARGET_MMX_WITH_SSE && vmode == V2SFmode)
- && !(TARGET_SSE2 && vmode == V2DFmode)
- && !(TARGET_SSE2 && vmode == V2DImode))
+ if (!(TARGET_SSE && (vmode == V4SFmode || vmode == V4SImode))
+ && !(TARGET_MMX_WITH_SSE && (vmode == V2SFmode || vmode == V2SImode))
+ && !(TARGET_SSE2 && (vmode == V2DFmode || vmode == V2DImode)))
return false;
/* Only the first element is changed. */
diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
index 0deccc2d2f4..f9c66115f81 100644
--- a/gcc/config/i386/mmx.md
+++ b/gcc/config/i386/mmx.md
@@ -1518,11 +1518,11 @@
(set_attr "prefix" "*,maybe_vex,orig")
(set_attr "mode" "DI,V4SF,V4SF")])
-(define_insn "*mmx_movss"
- [(set (match_operand:V2SF 0 "register_operand" "=x,v")
- (vec_merge:V2SF
- (match_operand:V2SF 2 "register_operand" " x,v")
- (match_operand:V2SF 1 "register_operand" " 0,v")
+(define_insn "*mmx_movss_<mode>"
+ [(set (match_operand:V2FI 0 "register_operand" "=x,v")
+ (vec_merge:V2FI
+ (match_operand:V2FI 2 "register_operand" " x,v")
+ (match_operand:V2FI 1 "register_operand" " 0,v")
(const_int 1)))]
"TARGET_MMX_WITH_SSE"
"@
reply other threads:[~2023-03-14 17:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314174147.94D6F3858D33@sourceware.org \
--to=uros@gcc.gnu.org \
--cc=gcc-cvs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).