public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-7123] PR target/109402: v850 (not v850e) variant of __muldi3() moves sp in reversed direction [PR109402]
@ 2023-04-08 14:26 Jeff Law
  0 siblings, 0 replies; only message in thread
From: Jeff Law @ 2023-04-08 14:26 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:79fb2de020c499bd01708e1418965a11166b7d5b

commit r13-7123-g79fb2de020c499bd01708e1418965a11166b7d5b
Author: Tetsuma Hoshino <t-hoshino@pony-e.jp>
Date:   Sat Apr 8 08:19:53 2023 -0600

    PR target/109402: v850 (not v850e) variant of __muldi3() moves sp in reversed direction [PR109402]
    
    muldi3 will deallocate stack space after the call to __save_r26_r31,
    then re-allocate the space a short while later.  If an interrupt
    occurs in that window, it can clobber items on the stack.
    
            PR target/109402
    
    libgcc/
            * config/v850/lib1funcs.S (___muldi3): Remove unnecessary
            stack manipulations.

Diff:
---
 libgcc/config/v850/lib1funcs.S | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libgcc/config/v850/lib1funcs.S b/libgcc/config/v850/lib1funcs.S
index 20fa499fa6d..35b5ab5f339 100644
--- a/libgcc/config/v850/lib1funcs.S
+++ b/libgcc/config/v850/lib1funcs.S
@@ -2211,7 +2211,6 @@ ___ucmpdi2:
 ___muldi3:
 #ifdef __v850__
         jarl  __save_r26_r31, r10
-        addi  16,  sp, sp
         mov   r6,  r28
         shr   15,  r28
         movea lo(32767), r0, r14
@@ -2256,7 +2255,6 @@ ___muldi3:
         mulh  r12, r6
         mov   r28,  r17
         mulh  r10, r17
-        add   -16, sp
         mov   r28,  r12
         mulh  r8,  r12
         add   r17, r18

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-08 14:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-08 14:26 [gcc r13-7123] PR target/109402: v850 (not v850e) variant of __muldi3() moves sp in reversed direction [PR109402] Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).