From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id AD1353857739; Sat, 22 Apr 2023 22:02:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD1353857739 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1682200965; bh=aq4ou5OzvLUZzvsMGNIjEKImrMQPyDgIBTCqWM2C9YA=; h=From:To:Subject:Date:From; b=OlqGRi2XcaIExVUoJKy6kZTxa+8ZoO+E+sEaRaJ8nlMjL+IqGkRdTWjBG+6UVNukk WKDN615jez8lvc4bvY2FAWWFOD/ccq4HR8kdxL/vQuaepL2YlSaI18aWJDNqyh/pQ+ 917ZR+shCGdhHt806R2lHVG8IflQq9arO00ed8TQ= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-170] PHIOPT: Improve readability of tree_ssa_phiopt_worker X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 84325f1c6aa3c52600ff558c4cfd028ec07b076a X-Git-Newrev: e81b29a53948c413a480a3288f0f386372e2b4f7 Message-Id: <20230422220245.AD1353857739@sourceware.org> Date: Sat, 22 Apr 2023 22:02:45 +0000 (GMT) List-Id: https://gcc.gnu.org/g:e81b29a53948c413a480a3288f0f386372e2b4f7 commit r14-170-ge81b29a53948c413a480a3288f0f386372e2b4f7 Author: Andrew Pinski Date: Wed Apr 19 14:42:45 2023 -0700 PHIOPT: Improve readability of tree_ssa_phiopt_worker This small patch just changes around the code slightly to make it easier to understand that the cases were handling diamond shaped BB for both do_store_elim/do_hoist_loads. There is no effect on code output at all since all of the checks are the same still. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. gcc/ChangeLog: * tree-ssa-phiopt.cc (tree_ssa_phiopt_worker): Change the code around slightly to move diamond handling for do_store_elim/do_hoist_loads out of the big if/else. Diff: --- gcc/tree-ssa-phiopt.cc | 46 +++++++++++++++++++++------------------------- 1 file changed, 21 insertions(+), 25 deletions(-) diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc index 8c5c8d8c250..d886c88215b 100644 --- a/gcc/tree-ssa-phiopt.cc +++ b/gcc/tree-ssa-phiopt.cc @@ -175,28 +175,38 @@ tree_ssa_phiopt_worker (bool do_store_elim, bool do_hoist_loads, bool early_p) std::swap (bb1, bb2); std::swap (e1, e2); } - else if (do_store_elim - && EDGE_SUCC (bb1, 0)->dest == EDGE_SUCC (bb2, 0)->dest) + else if (EDGE_SUCC (bb1, 0)->dest == EDGE_SUCC (bb2, 0)->dest) + { + diamond_p = true; + e2 = EDGE_SUCC (bb2, 0); + } + else + continue; + + e1 = EDGE_SUCC (bb1, 0); + + /* Make sure that bb1 is just a fall through. */ + if (!single_succ_p (bb1) + || (e1->flags & EDGE_FALLTHRU) == 0) + continue; + + if (do_store_elim && diamond_p) { - basic_block bb3 = EDGE_SUCC (bb1, 0)->dest; + basic_block bb3 = e1->dest; - if (!single_succ_p (bb1) - || (EDGE_SUCC (bb1, 0)->flags & EDGE_FALLTHRU) == 0 - || !single_succ_p (bb2) - || (EDGE_SUCC (bb2, 0)->flags & EDGE_FALLTHRU) == 0 + if (!single_succ_p (bb2) + || (e2->flags & EDGE_FALLTHRU) == 0 || EDGE_COUNT (bb3->preds) != 2) continue; if (cond_if_else_store_replacement (bb1, bb2, bb3)) cfgchanged = true; continue; } - else if (do_hoist_loads - && EDGE_SUCC (bb1, 0)->dest == EDGE_SUCC (bb2, 0)->dest) + else if (do_hoist_loads && diamond_p) { - basic_block bb3 = EDGE_SUCC (bb1, 0)->dest; + basic_block bb3 = e1->dest; if (!FLOAT_TYPE_P (TREE_TYPE (gimple_cond_lhs (cond_stmt))) - && single_succ_p (bb1) && single_succ_p (bb2) && single_pred_p (bb1) && single_pred_p (bb2) @@ -209,20 +219,6 @@ tree_ssa_phiopt_worker (bool do_store_elim, bool do_hoist_loads, bool early_p) hoist_adjacent_loads (bb, bb1, bb2, bb3); continue; } - else if (EDGE_SUCC (bb1, 0)->dest == EDGE_SUCC (bb2, 0)->dest) - { - diamond_p = true; - e2 = EDGE_SUCC (bb2, 0); - } - else - continue; - - e1 = EDGE_SUCC (bb1, 0); - - /* Make sure that bb1 is just a fall through. */ - if (!single_succ_p (bb1) - || (e1->flags & EDGE_FALLTHRU) == 0) - continue; if (do_store_elim && !diamond_p) {