public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: hongtao Liu <liuhongt@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-172] Use NO_REGS in cost calculation when the preferred register class are not known yet.
Date: Sun, 23 Apr 2023 01:57:22 +0000 (GMT)	[thread overview]
Message-ID: <20230423015722.2DC57385840A@sourceware.org> (raw)

https://gcc.gnu.org/g:0368d169492017cfab5622d38b15be94154d458c

commit r14-172-g0368d169492017cfab5622d38b15be94154d458c
Author: liuhongt <hongtao.liu@intel.com>
Date:   Wed Feb 8 12:42:27 2023 +0800

    Use NO_REGS in cost calculation when the preferred register class are not known yet.
    
    gcc/ChangeLog:
    
            PR rtl-optimization/108707
            * ira-costs.cc (scan_one_insn): Use NO_REGS instead of
            GENERAL_REGS when preferred reg_class is not known.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/i386/pr108707.c: New test.

Diff:
---
 gcc/ira-costs.cc                         |  5 ++++-
 gcc/testsuite/gcc.target/i386/pr108707.c | 16 ++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/gcc/ira-costs.cc b/gcc/ira-costs.cc
index c0fdef807dd..d2a801ab9b0 100644
--- a/gcc/ira-costs.cc
+++ b/gcc/ira-costs.cc
@@ -1572,7 +1572,10 @@ scan_one_insn (rtx_insn *insn)
       && (! ira_use_lra_p || ! pic_offset_table_rtx
 	  || ! contains_symbol_ref_p (XEXP (note, 0))))
     {
-      enum reg_class cl = GENERAL_REGS;
+      /* Costs for NO_REGS are used in cost calculation on the
+	 1st pass when the preferred register classes are not
+	 known yet.  In this case we take the best scenario.  */
+      enum reg_class cl = NO_REGS;
       rtx reg = SET_DEST (set);
       int num = COST_INDEX (REGNO (reg));
 
diff --git a/gcc/testsuite/gcc.target/i386/pr108707.c b/gcc/testsuite/gcc.target/i386/pr108707.c
new file mode 100644
index 00000000000..6405cfe7cdc
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr108707.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-mavx512f -O2" } */
+/* { dg-final { scan-assembler-not {(?n)vfmadd[1-3]*ps.*\(} { target { ! ia32 } } } } */
+/* { dg-final { scan-assembler-times {(?n)vfmadd[1-3]*ps[ \t]*} 3 } } */
+
+#include<immintrin.h>
+
+void
+foo (__m512 pv, __m512 a, __m512 b, __m512 c,
+     __m512* pdest, __m512* p1)
+{
+  __m512 t = *p1;
+    pdest[0] = _mm512_fmadd_ps (t, pv, a);
+    pdest[1] = _mm512_fmadd_ps (t, pv, b);
+    pdest[2] = _mm512_fmadd_ps (t, pv, c);
+}

                 reply	other threads:[~2023-04-23  1:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230423015722.2DC57385840A@sourceware.org \
    --to=liuhongt@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).